Message 222457 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	taleinat
Recipients	ezio.melotti, lemburg, loewis, taleinat, terry.reedy
Date	2014-07-07.12:45:47
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
@Martin: > 1. This issue is only about identifiers. So processing of > string literals is technically out of scope. I added a test with a non-ASCII string literal only for good measure, while I was already adding a test with a non-ASCII identifier. The patch doesn't change anything in that regard. Supporting Unicode string literals could be considered a separate issue, though the root cause of the problems is the same, and fixing it properly will fix both issues. > 2. I'd suggest to replace .translate with regular expressions: Indeed, something along those lines should work well, and probably would be fast enough.

@Martin:

> 1. This issue is only about identifiers. So processing of
> string literals is technically out of scope.

I added a test with a non-ASCII string literal only for good measure, while I was already adding a test with a non-ASCII identifier. The patch doesn't change anything in that regard. Supporting Unicode string literals could be considered a separate issue, though the root cause of the problems is the same, and fixing it properly will fix both issues.

> 2. I'd suggest to replace .translate with regular expressions:

Indeed, something along those lines should work well, and probably would be fast enough.

History
Date	User	Action	Args
2014-07-07 12:45:47	taleinat	set	recipients: + taleinat, lemburg, loewis, terry.reedy, ezio.melotti
2014-07-07 12:45:47	taleinat	set	messageid: <[email protected]>
2014-07-07 12:45:47	taleinat	link	issue21765 messages
2014-07-07 12:45:47	taleinat	create