Message 311487 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	malin
Recipients	malin, ned.deily, paul.moore, skn78, steve.dower, thatiparthy, tim.golden, tjguk, zach.ware
Date	2018-02-02.09:47:21
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
Glad to see PR 5468 not merged, I found it makes socket.py complicated. Now I'm inclined to patch the code in PyInit__socket(void) of socketmodule.c https://github.com/python/cpython/blob/3.6/Modules/socketmodule.c#L6504 There already has a MS-Windows version checking https://github.com/python/cpython/blob/3.6/Modules/socketmodule.c#L6511 In there, we can use GetVersionEx instead of GetVersion to get BuildNumber, then delete unusable opinions. (I don't have enough skill to modify .c code)

Glad to see PR 5468 not merged, I found it makes socket.py complicated.

Now I'm inclined to patch the code in PyInit__socket(void) of socketmodule.c
https://github.com/python/cpython/blob/3.6/Modules/socketmodule.c#L6504

There already has a MS-Windows version checking
https://github.com/python/cpython/blob/3.6/Modules/socketmodule.c#L6511

In there, we can use GetVersionEx instead of GetVersion to get BuildNumber, then delete unusable opinions.

(I don't have enough skill to modify .c code)

History
Date	User	Action	Args
2018-02-02 09:47:21	malin	set	recipients: + malin, paul.moore, tim.golden, ned.deily, zach.ware, steve.dower, thatiparthy, tjguk, skn78
2018-02-02 09:47:21	malin	set	messageid: <[email protected]>
2018-02-02 09:47:21	malin	link	issue32394 messages
2018-02-02 09:47:21	malin	create