Message 329123 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	serhiy.storchaka, vstinner
Date	2018-11-02.10:55:53
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
> There are not just two sides. It is common to wrap new stable C API with something like: > #if !defined(Py_LIMITED_API) \|\| Py_LIMITED_API+0 >= 0x03050000 > What will you do with this? objimpl.h always includes pycapi/pycapi_objimpl.h, so I don't think that we need a strong rules. I propose to always add move code using "#if ... Py_LIMITED_API" to the pycapi/ subdirectory, even if it uses "#if !defined(Py_LIMITED_API)".

> There are not just two sides. It is common to wrap new stable C API with something like:
> #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03050000
> What will you do with this?

objimpl.h always includes pycapi/pycapi_objimpl.h, so I don't think that we need a strong rules. I propose to always add move code using "#if ... Py_LIMITED_API" to the pycapi/ subdirectory, even if it uses "#if !defined(Py_LIMITED_API)".

History
Date	User	Action	Args
2018-11-02 10:55:53	vstinner	set	recipients: + vstinner, serhiy.storchaka
2018-11-02 10:55:53	vstinner	set	messageid: <[email protected]>
2018-11-02 10:55:53	vstinner	link	issue35134 messages
2018-11-02 10:55:53	vstinner	create