Message371206
The quote from #32989 is from my msg313179, msg313179.
There are two levels of duplication. First, between Hyperparser and EditorWindow. Second between editor and shell branches. While I said before to resolve the first with an EditorWindow method, as done in the patch, a hyperparser function, with 'self' replaced by 'editwin' would be possible. I might prefer that.
The second level of duplication could be handled by a method in EditorWindow overridden by a method in PyShell. But with duplication between the branches removed as in the patch, leaving the Shell branch so short, this does not seem as worthwhile. I suspect/expect it would be even less so after future Shell changes. |
|
| Date |
User |
Action |
Args |
| 2020-06-10 14:26:52 | terry.reedy | set | recipients:
+ terry.reedy, taleinat, cheryl.sabella |
| 2020-06-10 14:26:52 | terry.reedy | set | messageid: <[email protected]> |
| 2020-06-10 14:26:52 | terry.reedy | link | issue39666 messages |
| 2020-06-10 14:26:52 | terry.reedy | create | |
|