Message 384730 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pombredanne
Recipients	X-Istence, a.badger, barry, christian.heimes, dhess, l0nwlf, martin.panter, maxking, pitrou, pombredanne, r.david.murray, sascha_silbe, siona, sivert, steve.dower, terry.reedy, wichert, wodny
Date	2021-01-09.15:22:28
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
The changes introduced by this ticket in https://github.com/python/cpython/commit/9fc720e5e4f772598013ea48a3f0d22b2b6b04fa#r45794801 are problematic. I discovered this from having tests failing when testing on Python 3.7 and up The bug is that calling mimetypes.init(files) will NOT use my files, but instead use both my files and knownfiles. This was not the case before as knownfiles would be ignored as expected when I provide my of files list. This is a breaking API change IMHO and introduces a buggy unstability : even if I want to ignore knownfiles by providing my list of of files, knownfiles will always be added and this results in erratic and buggy behaviour as the content of "knownfiles" is completely random based on the OS version and else. The code I am using is here https://github.com/nexB/typecode/blob/ba07c04d23441d3469dc5de911376d408514ebd8/src/typecode/contenttype.py#L308 I think we should reopen to fix (or create a new ticket)

The changes introduced by this ticket in https://github.com/python/cpython/commit/9fc720e5e4f772598013ea48a3f0d22b2b6b04fa#r45794801 are problematic.

I discovered this from having tests failing when testing on Python 3.7 and up

The bug is that calling mimetypes.init(files) will NOT use my files, but instead use both my files and knownfiles.
This was not the case before as knownfiles would be ignored as expected when I provide my of files list.

This is a breaking API change IMHO and  introduces a buggy unstability : even if I want to ignore knownfiles by providing my list of of files, knownfiles will always be added and this results in erratic and buggy behaviour as the content of "knownfiles" is completely random based on the OS version and else. 

The code I am using is here https://github.com/nexB/typecode/blob/ba07c04d23441d3469dc5de911376d408514ebd8/src/typecode/contenttype.py#L308

I think we should reopen to fix (or create a new ticket)

History
Date	User	Action	Args
2021-01-09 15:22:29	pombredanne	set	recipients: + pombredanne, barry, terry.reedy, pitrou, christian.heimes, wichert, a.badger, r.david.murray, siona, sascha_silbe, l0nwlf, X-Istence, martin.panter, steve.dower, wodny, maxking, sivert, dhess
2021-01-09 15:22:29	pombredanne	set	messageid: <[email protected]>
2021-01-09 15:22:29	pombredanne	link	issue4963 messages
2021-01-09 15:22:28	pombredanne	create