➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gvanrossum
Recipients brett.cannon, christian.heimes, gvanrossum
Date 2007-10-16.18:43:26
SpamBayes Score 0.00038798572
Marked as misclassified No
Message-id <[email protected]>
In-reply-to <[email protected]>
Content 
Does this mean I should hold off reviewing the patch?

On 10/16/07, Christian Heimes <[email protected]> wrote:
>
> Christian Heimes added the comment:
>
> Christian Heimes wrote:
> >  * removed unused import of open in initstdio()
> >  * fixed infinite loop in PyTokenizer_FindEncoding() by checking
> > tok-done == E_OK
>
> I found another bug in Python/import.c:call_find_method. The function
> mustn't set an encoding of ftp->mode contains 'b' for binary.
>
>                 if (strchr(fdp->mode, 'b') == NULL) {
>                         /* Python text file, get encoding from tokenizer */
>                         encoding = PyTokenizer_FindEncoding(fp);
>                         encoding = (encoding != NULL) ? encoding :
>                                    PyUnicode_GetDefaultEncoding();
>                 }
>
> Christian
>
> __________________________________
> Tracker <[email protected]>
> <http://bugs.python.org/issue1267>
> __________________________________
>
History
Date User Action Args
2007-10-16 18:43:27gvanrossumsetspambayes_score: 0.000387986 -> 0.00038798572
recipients: + gvanrossum, brett.cannon, christian.heimes
2007-10-16 18:43:27gvanrossumlinkissue1267 messages
2007-10-16 18:43:27gvanrossumcreate