Message 63306 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	georg.brandl
Recipients	georg.brandl, gpolo, loewis
Date	2008-03-06.06:59:39
SpamBayes Score	0.048621085
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
Patch review: * ItimerError should be signal.ItimerError, not signal.error. * It should probably inherit from EnvironmentError or IOError. * itimer_retval will leak the new tuple if one of the PyFloat_FromDouble fails. * Do you have test and doc patches, too? * What does the "which" argument mean, is it an arbitrary integer identifying the timer?

Patch review:
* ItimerError should be signal.ItimerError, not signal.error.
* It should probably inherit from EnvironmentError or IOError.
* itimer_retval will leak the new tuple if one of the PyFloat_FromDouble
fails.
* Do you have test and doc patches, too?
* What does the "which" argument mean, is it an arbitrary integer
identifying the timer?

History
Date	User	Action	Args
2008-03-06 06:59:42	georg.brandl	set	spambayes_score: 0.0486211 -> 0.048621085 recipients: + georg.brandl, loewis, gpolo
2008-03-06 06:59:42	georg.brandl	set	spambayes_score: 0.0486211 -> 0.0486211 messageid: <[email protected]>
2008-03-06 06:59:40	georg.brandl	link	issue2240 messages
2008-03-06 06:59:39	georg.brandl	create