Message 66557 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rbp
Recipients	christian.heimes, pitrou, rbp
Date	2008-05-10.18:39:21
SpamBayes Score	0.002825326
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
The patch works for me, and I agree the test_xmlrpc is an xmlrpc issue. Perhaps unrelated to this issue, but I think it makes this whole unicode getargs situation fragile: I could not understand why the 'z' case (on the switch where this patch applies, starting on line 879 on the patched file) does a PyString_Check(arg) and a PyUnicode_Check(arg), while the corresponding section on case 's' (line 813) only does PyUnicode_Check(arg). Is this really an inconsistency? Maybe this should go into an issue to cleanup this switch, according to the comment at its beginning: /* XXX WAAAAH! 's', 'y', 'z', 'u', 'Z', 'e', 'w', 't' codes all need to be cleaned up! */

The patch works for me, and I agree the test_xmlrpc is an xmlrpc issue.

Perhaps unrelated to this issue, but I think it makes this whole unicode
getargs situation fragile: I could not understand why the 'z' case (on
the switch where this patch applies, starting on line 879 on the patched
file) does a PyString_Check(arg) and a PyUnicode_Check(arg), while the
corresponding section on case 's' (line 813) only does PyUnicode_Check(arg).

Is this really an inconsistency? Maybe this should go into an issue to
cleanup this switch, according to the comment at its beginning:

	/* XXX WAAAAH!  's', 'y', 'z', 'u', 'Z', 'e', 'w', 't' codes all
	   need to be cleaned up! */

History
Date	User	Action	Args
2008-05-10 18:39:23	rbp	set	spambayes_score: 0.00282533 -> 0.002825326 recipients: + rbp, pitrou, christian.heimes
2008-05-10 18:39:23	rbp	set	spambayes_score: 0.00282533 -> 0.00282533 messageid: <[email protected]>
2008-05-10 18:39:22	rbp	link	issue2798 messages
2008-05-10 18:39:21	rbp	create