Message 77880 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	lemburg
Recipients	lemburg, pitrou, rhettinger
Date	2008-12-15.19:27:57
SpamBayes Score	2.9223042e-05
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to	<1229355265.12181.6.camel@localhost>

Content
On 2008-12-15 16:34, Antoine Pitrou wrote: > Antoine Pitrou <[email protected]> added the comment: > > Le lundi 15 décembre 2008 à 14:41 +0000, Marc-Andre Lemburg a écrit : >> Why have you removed the complete error handling section in >> PyUnicode_RichCompare() ? > > Because the only error that can occur is a TypeError when one of the two > arguments is not an unicode object, and that is handled by returning > Py_NotImplemented at the end. > (there is no implicit bytes -> unicode coercion anymore, and therefore > things are much simpler) Ah, sorry, just saw that this is just for Py3. The fast-path would probably also make sense for Py2 (keeping the error handling, of course).

On 2008-12-15 16:34, Antoine Pitrou wrote:
> Antoine Pitrou <[email protected]> added the comment:
> 
> Le lundi 15 décembre 2008 à 14:41 +0000, Marc-Andre Lemburg a écrit :
>> Why have you removed the complete error handling section in
>> PyUnicode_RichCompare() ?
> 
> Because the only error that can occur is a TypeError when one of the two
> arguments is not an unicode object, and that is handled by returning
> Py_NotImplemented at the end.
> (there is no implicit bytes -> unicode coercion anymore, and therefore
> things are much simpler)

Ah, sorry, just saw that this is just for Py3.

The fast-path would probably also make sense for Py2 (keeping the
error handling, of course).

History
Date	User	Action	Args
2008-12-15 19:27:58	lemburg	set	recipients: + lemburg, rhettinger, pitrou
2008-12-15 19:27:57	lemburg	link	issue3106 messages
2008-12-15 19:27:57	lemburg	create