Message79317
Matthias Klose schrieb:
> there are some problems with ctypes.util.find_library(), which I would
> like to see fixed on active branches.
>
> - find_library is not robust, if either objdump or gcc are not
> installed. fixed by raising an exception if the tools are not
> found. Is OSError the correct type for this exception?
Sure.
> - ldconfig -p already prints the shared object name. afaics there
> is no need to call objdump again.
> - the regexp to scan the ldconfig -p output is wrong for
> architectures where libraries of more than one abi type are
> installed, e.g. having ix86 libs on a x86_64 system. Having
> only the library installed which doesn't match the python
> executable lets find_library find the wrong library. Note that
> the patch is only correct under the assumption that the python
> executable is unstalled for the "main" abi.
I have to trust you that this is the right approach since I don't have
much experience on linux. Also I have not tested the patch.
What I do not like too much in your patch is 'import platform'
since that pulls in a lot of stuff. Would it be possible to
replace 'platform.machine()' with 'os.uname()[4]' ? |
|
| Date |
User |
Action |
Args |
| 2009-01-07 10:26:47 | theller | set | recipients:
+ theller, doko |
| 2009-01-07 10:26:46 | theller | link | issue4861 messages |
| 2009-01-07 10:26:45 | theller | create | |
|