Add a null check to method TestUtils.compressHeapDumps.#10053
Merged
normanmaurer merged 1 commit intonetty:4.1from Feb 25, 2020
Merged
Add a null check to method TestUtils.compressHeapDumps.#10053normanmaurer merged 1 commit intonetty:4.1from
normanmaurer merged 1 commit intonetty:4.1from
Conversation
|
Can one of the admins verify this patch? |
normanmaurer
approved these changes
Feb 24, 2020
Member
|
@netty-bot test this please |
normanmaurer
pushed a commit
that referenced
this pull request
Feb 25, 2020
Motivation: java.io.File.listFiles() may return null and cause a unexpected NPE. Modification: Add a null check for variable files. And if variable files is null, the compressHeapDumps method will just return after logging a error message. Result: Fix the potential NPE.
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
Motivation: java.io.File.listFiles() may return null and cause a unexpected NPE. Modification: Add a null check for variable files. And if variable files is null, the compressHeapDumps method will just return after logging a error message. Result: Fix the potential NPE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
java.io.File.listFiles() may return null and cause a unexpected NPE.
Modification:
Add a null check for variable files. And if variable files is null, the compressHeapDumps method will just return after logging a error message.
Result:
Fix the potential NPE.