Skip to content
This repository was archived by the owner on Jan 14, 2018. It is now read-only.

coordinatorAnimations were only set for the default animation controller#387

Open
dbachrach wants to merge 3 commits intoECSlidingViewController:masterfrom
dbachrach:master
Open

coordinatorAnimations were only set for the default animation controller#387
dbachrach wants to merge 3 commits intoECSlidingViewController:masterfrom
dbachrach:master

Conversation

@dbachrach
Copy link
Copy Markdown

Addresses #356.

The coordinatorAnimations and coordinatorCompletion blocks are only set for the defaultAnimationController. Custom animation controller's cannot take advantage of coordinated transitions and use animateAlongside:. A proposed fix is to set the coordinatorAnimations and coordinatorCompletion for all operations, not just the default one. Feedback?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant