Fix RenderParagraph.textAlign setter to call markNeedsLayout #179881
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The textAlign setter was only calling markNeedsPaint(), which meant that parent widgets using LayoutBuilder would not be notified when text alignment changed. This fix changes it to call markNeedsLayout() instead, consistent with other setters like textDirection and softWrap that affect layout. Fixes flutter#140756
github-actions
bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly changes the textAlign setter in RenderParagraph to call markNeedsLayout() instead of markNeedsPaint(). This change ensures that modifying the text alignment properly invalidates the layout, which is consistent with other layout-related properties in the class. The test for this behavior has also been updated to reflect the fix, now correctly asserting that debugNeedsLayout is true after the property change and using pumpFrame() to process the layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you change
textAlignon aRenderParagraph, the parent widget doesn't know the layout changed.Example: If you use
LayoutBuilderto position elements based on text alignment, changing fromTextAlign.lefttoTextAlign.rightwon't trigger a rebuild - even though the text moved.Cause
The
textAlignsetter was callingmarkNeedsPaint()(just repaint) instead ofmarkNeedsLayout()(recalculate layout).Fix
One line change:
markNeedsPaint()→markNeedsLayout()This matches how other setters like
textDirectionandsoftWrapalready work.Fixes
#140756
Pre-launch Checklist
///).