Skip to content

Improve Vertex handling in MCEventHeader#15147

Open
jackal1-66 wants to merge 1 commit intoAliceO2Group:devfrom
jackal1-66:fixVertex
Open

Improve Vertex handling in MCEventHeader#15147
jackal1-66 wants to merge 1 commit intoAliceO2Group:devfrom
jackal1-66:fixVertex

Conversation

@jackal1-66
Copy link
Collaborator

@jackal1-66 jackal1-66 commented Mar 11, 2026

ExtKinO2 is set as the only generator which preserves original vertex information. This is done both in basic usage and in Hybrid mode. A full reset of the underlying generator header in hybrid was needed, otherwise when using extkinO2/event-pools together with other generators some info where kept from one event to the other (no hard reset on base FairMCEventHeader class info).

@jackal1-66 jackal1-66 requested a review from sawenzel as a code owner March 11, 2026 10:11
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

if (mGens[mHeaderGeneratorIndex] != "extkinO2") {
mMCEventHeader.SetVertex(eventHeader->GetX(), eventHeader->GetY(), eventHeader->GetZ());
}
mHeaderGeneratorIndex = -1; // reset header generator index for next event
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it here be simply possible to delegate to mGens[mHeaderGeneratorIndex]->updateHeader() to do whatever it has to do? The if looks a bit awkward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants