Merged
Conversation
The library will itself now track the optional parameters and if rpc-call doesn't supply a value for an optional value for the parameter, it'll be automatically setting a default value for it.
Collaborator
Author
|
For the sake of consistency, here is the reference & use-case discussion on it; https://jsonrpc2.codeplex.com/discussions/537268 |
added 2 commits
March 6, 2014 14:42
…ount by one each time we add default-value for an optional parameter that rpc-call didn't set a value for.
Owner
|
Looks great! I will be pulling this in tonight, should be able to add a few tests and publish a new release build in the next few days. Thanks again for the good work. |
Astn
added a commit
that referenced
this pull request
Mar 7, 2014
Added optional params support. -RastlinTheWiz
Collaborator
Author
|
Though i only implemented it for arrays as for objects it's already all good (at least should be). ü And yep we need proper tests I may have fixed some cases where the changes my cause problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library will itself now track the optional parameters and if rpc-call doesn't supply a value for an optional value for the parameter, it'll be automatically setting a default value for it.