Skip to content

Possibility to specify a method parameter name as it will be referred to by JsonRpc #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rommar wants to merge 1 commit into from
Closed

Possibility to specify a method parameter name as it will be referred to by JsonRpc #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Json-Rpc/Attributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,27 @@ public string JsonMethodName
get { return jsonMethodName; }
}
}

/// <summary>
/// Used to assign JsonRpc parameter name to method argument.
/// </summary>
[AttributeUsage(AttributeTargets.Parameter, Inherited = false, AllowMultiple = false)]
public sealed class JsonRpcParamAttribute : Attribute
{
readonly string jsonParamName;

/// <summary>
/// Used to assign JsonRpc parameter name to method argument.
/// </summary>
/// <param name="jsonParamName">Lets you specify the parameter name as it will be referred to by JsonRpc.</param>
public JsonRpcParamAttribute(string jsonParamName = "")
{
this.jsonParamName = jsonParamName;
}

public string JsonParamName
{
get { return jsonParamName; }
}
}
}
17 changes: 14 additions & 3 deletions Json-Rpc/JsonRpcService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,25 @@ private void buildService(string sessionID)
var paramzs = meth.GetParameters();

List<Type> parameterTypeArray = new List<Type>();
for (int i = 0; i < paramzs.Length; i++)
for (int i = 0; i < paramzs.Length; i++)
{
string paramName;
var paramAttrs = paramzs[i].GetCustomAttributes(typeof(JsonRpcParamAttribute), false);
if (paramAttrs.Length > 0)
{
paramName = ((JsonRpcParamAttribute)paramAttrs[0]).JsonParamName;
}
else
{
paramName = paramzs[i].Name;
}

// reflection attribute information for optional parameters
//http://stackoverflow.com/questions/2421994/invoking-methods-with-optional-parameters-through-reflection
paras.Add(paramzs[i].Name, paramzs[i].ParameterType);
paras.Add(paramName, paramzs[i].ParameterType);

if (paramzs[i].IsOptional) // if the parameter is an optional, add the default value to our default values dictionary.
defaultValues.Add(paramzs[i].Name, paramzs[i].DefaultValue);
defaultValues.Add(paramName, paramzs[i].DefaultValue);
}

var resType = meth.ReturnType;
Expand Down