Possibility to specify a method parameter name as it will be referred to by JsonRpc (with unit test)#58
Closed
rommar wants to merge 2 commits intoAstn:masterfrom
Closed
Possibility to specify a method parameter name as it will be referred to by JsonRpc (with unit test)#58rommar wants to merge 2 commits intoAstn:masterfrom
rommar wants to merge 2 commits intoAstn:masterfrom
Conversation
… to by JsonRpc; Corresponding unit test;
…default constructed). This will work the same way as with no attribute specified.
Contributor
Author
|
I added few changes to support usage of JsonRpcParam attribute with no specific parameter name: That doesn't make much sense to use it like this, but mainly serves the purpose of having similar style with JsonRpcMethod attribute. |
Owner
|
I've pulled these changes into #73 as I was unable to merge this due to conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is basically the same as my another pull request to support custom parameter names (#51) but with unit test added.