Skip to content

Support injecting middleware into generated app. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sportnak wants to merge 1 commit into from
Closed

Support injecting middleware into generated app. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion example/js/exampleApiServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ function parseBoolean(value) {
return undefined;
}

export function createApp(service) {
export function createApp(service, middleware) {
const app = express();
app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: true }));
middleware.forEach(func => app.use(func));

/** Gets widgets. */
app.get('/widgets', function (req, res, next) {
Expand Down
3 changes: 2 additions & 1 deletion example/ts/src/exampleApiServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ function parseBoolean(value: string | undefined) {
return undefined;
}

export function createApp(service: IExampleApi): express.Application {
export function createApp(service: IExampleApi, middleware: ((...args: any[]) => void)[]): express.Application {
const app = express();
app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: true }));
middleware.forEach(func => app.use(func));

/** Gets widgets. */
app.get('/widgets', function (req, res, next) {
Expand Down
3 changes: 2 additions & 1 deletion src/Facility.CodeGen.JavaScript/JavaScriptGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,12 @@ protected override CodeGenOutput GenerateOutputCore(ServiceInfo service)
}

code.WriteLine();
using (code.Block("export function createApp(service" + IfTypeScript($": I{capModuleName}") + ")" + IfTypeScript(": express.Application") + " {", "}"))
using (code.Block("export function createApp(service" + IfTypeScript($": I{capModuleName}") + ", middleware" + IfTypeScript(": ((...args: any[]) => void)[]") + ")" + IfTypeScript(": express.Application") + " {", "}"))
Copy link
Contributor

@ddunkin ddunkin Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

middleware should be optional.

{
code.WriteLine("const app = express();");
code.WriteLine("app.use(bodyParser.json());");
code.WriteLine("app.use(bodyParser.urlencoded({ extended: true }));");
code.WriteLine("middleware.forEach(func => app.use(func));");
Copy link
Contributor

@ddunkin ddunkin Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test if middleware is truthy.


foreach (var httpMethodInfo in httpServiceInfo.Methods)
{
Expand Down