Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/client_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Heldroe/client_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Oct 2, 2018

  1. Using direct assignment for writing into mmap instead of struct.pack_… 

    …into

Using pack_into can create atomicity problems when writing on cpython, setting the bytes to 0 before writing the value.
When having a lot of writes, some reads would return 0 instead of the real value.

Signed-off-by: David Guerrero <[email protected]>
    @Heldroe
    Heldroe committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    8ea7995 View commit details
    Browse the repository at this point in the history

  2. Adding the mmap write fix for integer writes, added a comment to clar… 

    …ify the issue.

Signed-off-by: David Guerrero <[email protected]>
    @Heldroe
    Heldroe committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    eaf5a42 View commit details
    Browse the repository at this point in the history
Loading