Improve once and limit: consistent-return

tshemsedinov · tshemsedinov · commit 240d9db04180 · 2024-02-16T00:11:54.000+02:00
diff --git a/JavaScript/7-once.js b/JavaScript/7-once.js
@@ -2,11 +2,17 @@
 
 // Wrapper will prevent calls > n
 
-const once = (f) => (...args) => {
-  if (!f) return;
-  const res = f(...args);
-  f = null;
-  return res;
+const emptiness = () => {};
+
+const once = (fn) => {
+  if (!fn) return emptiness;
+  let finished = false;
+  const wrapped = (...args) => {
+    if (finished) return;
+    finished = true;
+    fn(...args);
+  };
+  return wrapped;
 };
 
 // Usage
diff --git a/JavaScript/8-limit.js b/JavaScript/8-limit.js
@@ -2,13 +2,17 @@
 
 // Wrapper will prevent calls > n
 
-const limit = (count, f) => {
+const emptiness = () => {};
+
+const limit = (count, fn) => {
   let counter = 0;
-  return (...args) => {
-    if (counter === count) return;
+  if (!fn) return emptiness;
+  const wrapped = (...args) => {
+    if (counter === count) return null;
     counter++;
-    return f(...args);
+    return fn(...args);
   };
+  return wrapped;
 };
 
 // Usage
