Add sys_prefix option to mirror --sys-prefix#655
Merged
flying-sheep merged 1 commit intoIRkernel:masterfrom Apr 11, 2020
Merged
Add sys_prefix option to mirror --sys-prefix#655flying-sheep merged 1 commit intoIRkernel:masterfrom
flying-sheep merged 1 commit intoIRkernel:masterfrom
Conversation
flying-sheep
requested changes
Mar 31, 2020
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
Looks good! You have to add the docs to the roxygen2 comment though, and build the .Rd file using roxygen2.
rkdarst
force-pushed
the
rkdarst/sys-prefix
branch
from
84855de to
579e9cf
Compare
- Add installspec(sys_prefix=TRUE) option to install using the equivalent of --sys-prefix. Support added in jupyter-client 4.3 (2016). - Not tested yet, but user=TRUE doesn't seem to be either... - Also document just how these work, as a help to people who need to know this detail in order to manage an installation.
rkdarst
force-pushed
the
rkdarst/sys-prefix
branch
from
579e9cf to
0655665
Compare
Contributor
Author
|
OK, I managed to fix the doc issue, and added some more docs about it. In the process I found a syntax error in the R file, which is now fixed. So... any other suggestions? I still haven't given this any tests at all... I'm not that much of an R user! Maybe I can ask someone to help with that... |
Member
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my work deploying jupyter to people, I've been annoyed that there
is no
--sys-prefixequivalent for IRkernel. Well, maybe I should dosomething about it...
equivalent of --sys-prefix. Support added in jupyter-client 4.3
(2016). This is passed directly to the underlying
jupyter kernelspec installcommand.I'm not an R expert, and I haven't even tested this code myself. But
I figure that making prototype quickly is better than abstract
discussion, so here it is. This would have saved me plenty of time
over the years.
Whether or not this goes through, I will try to improve the
installation docs some - it would have also saved me time, as a
cluster manager who needs to know some more details about what's going
on.