Conversation
yuhattor
changed the title
bakisunsan
reviewed
Jun 21, 2023
Contributor
bakisunsan
left a comment
bakisunsan
left a comment
There was a problem hiding this comment.
日本語文のこの部分はすんなり意味が入ってこないな、という所中心にコメントさせていただきました
|
|
||
| ## Patlet | ||
|
|
||
| インナーソースプロジェクトは多くの貢献を受けており、メンテナンスが難しくなっています。メンテナは、プロジェクトのコア部分から離れた拡張機構を提供することで、最小のコストとメンテナンスオーバーヘッドでプロジェクトの能力をスケールアップすることを可能にします。 |
Contributor
There was a problem hiding this comment.
(質問) 質問なのですが、貢献、とコントリビューション、ってどちらの方が伝わりやすそうでしょうか？
他のドキュメントで貢献、となっているならこのままでよいと思います
Member
Author
There was a problem hiding this comment.
これ、悩ましいです。ルールはあまりないんですが
コントリビューション: GitHub でいうプロジェクトへの「コントリビューション」につながることはカタカナでそのまま書いています。Issue, PR, Code, Comment などなど、これらのものにつながることが期待されているのであれば「コントリビューション」としています。
もうすこし精神的な「貢献」であれば漢字を使いますが、インナーソースの文脈がそもそも GitHub / オープンソースなどの文脈であり、あんまり漢字で表されるものは多くない気がするんですよね
Member
Author
There was a problem hiding this comment.
なので、ほとんど「コントリビューション」のカタカナの方が採用されているとおもいます
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
LGTM です! Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: bakisunsan <[email protected]>
yuhattor
force-pushed
the
adding-extensions-for-sustainable-growth-ja-translation
branch
from
3d2231c to
0266cca
Compare
bakisunsan
reviewed
Jun 21, 2023
bakisunsan
reviewed
Jun 21, 2023
bakisunsan
approved these changes
Jun 21, 2023
Co-authored-by: tomoyuki kobayashi <[email protected]>
Co-authored-by: tomoyuki kobayashi <[email protected]>
yuhattor
deleted the
adding-extensions-for-sustainable-growth-ja-translation
branch
Member
Author
|
Thanks @bakisunsan! sorry for being late to merge it. I think it's ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translated the Extensions for Sustainable Growth pattern into Japanese
Tasks before merging the PR
I am currently calling for reviews and native checking via Slack.
https://innersourcecommons.slack.com/archives/C03M546NR16/p1687098743521129