Break apart so that it can be used with Netflix Github page#2
Merged
mtye merged 1 commit intoJavaPosseRoundup:masterfrom Feb 7, 2013
Merged
Break apart so that it can be used with Netflix Github page#2mtye merged 1 commit intoJavaPosseRoundup:masterfrom
mtye merged 1 commit intoJavaPosseRoundup:masterfrom
Conversation
…hout a particular JSON request.
mtye
added a commit
that referenced
this pull request
Feb 7, 2013
Break apart so that it can be used with Netflix Github page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to Github API throttling, the timeline thing is not working currently. This change breaks commits.js into two parts. The main part that does the work, commitsbase.js, and a small portion that makes the call, commitsaction.js. netflix.github.com only needs commitsbase.js.
I didn't touch the original commits.js. But, it should be deprecated. New users would include commitsbase.js then commitsaction.js.
So, until this pull is integrated, the timeline feature on netflix.github.com will stay broken. There's your incentive ;)