Remove deadwood TSLint suppressions

octogonz · octogonz · commit 2333526cf73d · 2019-10-21T16:37:18.000-07:00
diff --git a/apps/api-documenter/src/documenters/YamlDocumenter.ts b/apps/api-documenter/src/documenters/YamlDocumenter.ts
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-// tslint:disable:member-ordering
-
 import * as path from 'path';
 
 import yaml = require('js-yaml');
diff --git a/apps/api-extractor-model/src/items/ApiItem.ts b/apps/api-extractor-model/src/items/ApiItem.ts
@@ -231,7 +231,7 @@ export class ApiItem {
             // These functional forms don't have a proper name, so we don't append the "()" suffix
             break;
           default:
-            if (ApiParameterListMixin.isBaseClassOf(current)) { // tslint:disable-line:no-use-before-declare
+            if (ApiParameterListMixin.isBaseClassOf(current)) {
               reversedParts.push('()');
             }
         }
diff --git a/apps/api-extractor/src/analyzer/AstSymbolTable.ts b/apps/api-extractor/src/analyzer/AstSymbolTable.ts
@@ -379,7 +379,6 @@ export class AstSymbolTable {
     return referencedAstEntity;
   }
 
-  // tslint:disable-next-line:no-unused-variable
   private _fetchAstDeclaration(node: ts.Node, isExternal: boolean): AstDeclaration | undefined {
     if (!AstDeclaration.isSupportedSyntaxKind(node.kind)) {
       return undefined;
diff --git a/apps/api-extractor/src/generators/DtsRollupGenerator.ts b/apps/api-extractor/src/generators/DtsRollupGenerator.ts
@@ -71,7 +71,6 @@ export class DtsRollupGenerator {
 
     // Emit the triple slash directives
     for (const typeDirectiveReference of collector.dtsTypeReferenceDirectives) {
-      // tslint:disable-next-line:max-line-length
       // https://github.com/microsoft/TypeScript/blob/611ebc7aadd7a44a4c0447698bfda9222a78cb66/src/compiler/declarationEmitter.ts#L162
       stringWriter.writeLine(`/// <reference types="${typeDirectiveReference}" />`);
     }
diff --git a/apps/rush-lib/src/logic/TaskSelector.ts b/apps/rush-lib/src/logic/TaskSelector.ts
@@ -203,7 +203,6 @@ export class TaskSelector {
     const script: string | undefined = this._getScriptCommand(rushProject, this._options.commandToRun);
 
     if (script === undefined && !this._options.ignoreMissingScript) {
-      // tslint:disable-next-line:max-line-length
       throw new Error(`The project [${rushProject.packageName}] does not define a '${this._options.commandToRun}' command in the 'scripts' section of its package.json`);
     }
 
diff --git a/apps/rush-lib/src/logic/pnpm/PnpmLinkManager.ts b/apps/rush-lib/src/logic/pnpm/PnpmLinkManager.ts
@@ -210,7 +210,6 @@ export class PnpmLinkManager extends BaseLinkManager {
     const folderNameInLocalInstallationRoot: string = uriEncode(Text.replaceAll(absolutePathToTgzFile, path.sep, '/')) +
       folderNameSuffix;
 
-    // tslint:disable-next-line:max-line-length
     // e.g.: C:\wbt\common\temp\node_modules\.local\C%3A%2Fwbt%2Fcommon%2Ftemp%2Fprojects%2Fapi-documenter.tgz\node_modules
 
     const pathToLocalInstallation: string = this._getPathToLocalInstallation(folderNameInLocalInstallationRoot);
@@ -306,7 +305,6 @@ export class PnpmLinkManager extends BaseLinkManager {
 
     // FYI dependencyName might contain an NPM scope, here it gets converted into a filesystem folder name
     // e.g. if the dependency is supi:
-    // tslint:disable-next-line:max-line-length
     // "C:\wbt\common\temp\node_modules\.local\C%3A%2Fwbt%2Fcommon%2Ftemp%2Fprojects%2Fapi-documenter.tgz\node_modules\supi"
     const dependencyLocalInstallationSymlink: string = path.join(
       pathToLocalInstallation,
diff --git a/apps/rush-lib/src/logic/test/ChangelogGenerator.test.ts b/apps/rush-lib/src/logic/test/ChangelogGenerator.test.ts
@@ -136,7 +136,6 @@ describe('updateIndividualChangelog', () => {
       rushConfiguration
     )!;
 
-    /* tslint:disable-next-line:no-unused-expression */
     expect(actualResult).not.toBeDefined();
   });
 
diff --git a/apps/rush-lib/src/logic/test/PublishUtilities.test.ts b/apps/rush-lib/src/logic/test/PublishUtilities.test.ts
@@ -75,7 +75,6 @@ describe('findChangeRequests', () => {
   });
 
   it('returns 4 changes when hotfixing a root package', () => {
-    // tslint:disable-next-line no-any
     const allChanges: IChangeInfoHash = PublishUtilities.findChangeRequests(
       packagesRushConfiguration.projectsByName,
       packagesRushConfiguration,
@@ -282,13 +281,11 @@ describe('sortChangeRequests', () => {
 
 describe('isRangeDependency', () => {
   it('can test ranges', () => {
-    /* tslint:disable:no-unused-expression */
     expect(PublishUtilities.isRangeDependency('>=1.0.0 <2.0.0')).toEqual(true);
     expect(PublishUtilities.isRangeDependency('>=1.0.0-pr.1 <2.0.0')).toEqual(true);
     expect(PublishUtilities.isRangeDependency('1.0.0')).toEqual(false);
     expect(PublishUtilities.isRangeDependency('^1.0.0')).toEqual(false);
     expect(PublishUtilities.isRangeDependency('~1.0.0')).toEqual(false);
-    /* tslint:enable:no-unused-expression */
   });
 });
 
diff --git a/apps/rush-lib/src/utilities/AlreadyReportedError.ts b/apps/rush-lib/src/utilities/AlreadyReportedError.ts
@@ -12,7 +12,6 @@ export class AlreadyReportedError extends Error {
     super('An error occurred.');
 
     // Manually set the prototype, as we can no longer extend built-in classes like Error, Array, Map, etc
-    // tslint:disable-next-line:max-line-length
     // [https://github.com/microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work](https://github.com/microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work)
     //
     // Note: the prototype must also be set on any classes which extend this one
diff --git a/core-build/gulp-core-build-mocha/src/index.ts b/core-build/gulp-core-build-mocha/src/index.ts
@@ -10,4 +10,4 @@ export const instrument: InstrumentTask = new InstrumentTask();
 /** @public */
 export const mocha: MochaTask = new MochaTask();
 
-export default serial(instrument, mocha) as IExecutable; // tslint:disable-line:export-name no-any
+export default serial(instrument, mocha) as IExecutable;
diff --git a/core-build/gulp-core-build-sass/src/index.ts b/core-build/gulp-core-build-sass/src/index.ts
@@ -8,6 +8,4 @@ import { SassTask } from './SassTask';
  */
 export const sass: SassTask = new SassTask();
 
-/* tslint:disable:export-name */
 export default sass;
-/* tslint:enable:export-name */
diff --git a/core-build/gulp-core-build-serve/src/certificates.ts b/core-build/gulp-core-build-serve/src/certificates.ts
@@ -133,7 +133,7 @@ function _tryTrustCertificate(certificatePath: string, parentTask: GulpTask<{}>)
         return true;
       }
 
-    case 'darwin': // tslint:disable-line:no-switch-case-fall-through
+    case 'darwin':
       parentTask.log( 'Attempting to trust a dev certificate. This self-signed certificate only points to localhost ' +
                       'and will be stored in your local user profile to be used by other instances of ' +
                       'gulp-core-build-serve. If you do not consent to trust this certificate, do not enter your ' +
@@ -165,7 +165,7 @@ function _tryTrustCertificate(certificatePath: string, parentTask: GulpTask<{}>)
         }
       }
 
-    default: // tslint:disable-line:no-switch-case-fall-through
+    default:
       // Linux + others: Have the user manually trust the cert if they want to
       parentTask.log( 'Automatic certificate trust is only implemented for gulp-core-build-serve on Windows and ' +
                       'macOS. To trust the development certificate, add this certificate to your trusted root ' +
@@ -275,7 +275,7 @@ export function untrustCertificate<TGulpTask>(parentTask: GulpTask<TGulpTask>):
         return true;
       }
 
-    case 'darwin': // tslint:disable-line:no-switch-case-fall-through
+    case 'darwin':
       parentTask.logVerbose('Trying to find the signature of the dev cert');
 
       const macFindCertificateResult: child_process.SpawnSyncReturns<string> =
@@ -321,7 +321,7 @@ export function untrustCertificate<TGulpTask>(parentTask: GulpTask<TGulpTask>):
         return false;
       }
 
-    default: // tslint:disable-line:no-switch-case-fall-through
+    default:
       // Linux + others: Have the user manually untrust the cert
       parentTask.log( 'Automatic certificate untrust is only implemented for gulp-core-build-serve on Windows and ' +
                       'macOS. To untrust the development certificate, remove this certificate from your trusted ' +
diff --git a/core-build/gulp-core-build-serve/src/index.ts b/core-build/gulp-core-build-serve/src/index.ts
@@ -26,4 +26,4 @@ export const trustDevCert: TrustCertTask = new TrustCertTask();
  */
 export const untrustDevCert: UntrustCertTask = new UntrustCertTask();
 
-export default serve; // tslint:disable-line:export-name
+export default serve;
diff --git a/core-build/gulp-core-build-typescript/src/RSCTask.ts b/core-build/gulp-core-build-typescript/src/RSCTask.ts
@@ -31,7 +31,7 @@ export abstract class RSCTask<TTaskConfig extends IRSCTaskConfig> extends GulpTa
   // containing "@microsoft/rush-stack-compiler-*"
   private static _rushStackCompilerPackagePathCache: Map<string, string> = new Map<string, string>();
 
-  private static __packageJsonLookup: PackageJsonLookup | undefined; // tslint:disable-line:variable-name
+  private static __packageJsonLookup: PackageJsonLookup | undefined;
 
   private static get _packageJsonLookup(): PackageJsonLookup {
     if (!RSCTask.__packageJsonLookup) {
diff --git a/core-build/gulp-core-build-webpack/src/index.ts b/core-build/gulp-core-build-webpack/src/index.ts
@@ -12,5 +12,5 @@ export {
 /**
  * @public
  */
-export const webpack: WebpackTask = new WebpackTask(); // tslint:disable-line:export-name
-export default webpack; // tslint:disable-line:export-name
+export const webpack: WebpackTask = new WebpackTask();
+export default webpack;
diff --git a/core-build/gulp-core-build/src/GulpProxy.ts b/core-build/gulp-core-build/src/GulpProxy.ts
@@ -4,7 +4,6 @@
 import gulp = require('gulp');
 import Orchestrator = require('orchestrator');
 
-/* tslint:disable:max-line-length */
 /**
  * A helper utility for gulp which can be extended to provide additional features to gulp vinyl streams
  */
diff --git a/core-build/gulp-core-build/src/index.ts b/core-build/gulp-core-build/src/index.ts
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-/* tslint:disable:max-line-length */
-
 if (process.argv.indexOf('--no-color') === -1) {
   process.argv.push('--color');
 }
diff --git a/core-build/gulp-core-build/src/logging.ts b/core-build/gulp-core-build/src/logging.ts
@@ -148,18 +148,14 @@ function afterStreamFlushed(streamName: string, callback: () => void): void {
     const stream: NodeJS.WritableStream = process[streamName];
     const outputWritten: boolean = stream.write('');
     if (outputWritten) {
-      /* tslint:disable:ban-native-functions */
       setTimeout(() => {
         callback();
       }, 250);
-      /* tslint:enable:ban-native-functions */
     } else {
       stream.once('drain', () => {
-        /* tslint:disable:ban-native-functions */
         setTimeout(() => {
           callback();
         }, 250);
-        /* tslint:enable:ban-native-functions */
       });
     }
   }
@@ -284,7 +280,6 @@ function wireUpProcessErrorHandling(shouldWarningsFailBuild: boolean): void {
 
     if (shouldWarningsFailBuild) {
       const oldStdErr: Function = process.stderr.write;
-      // tslint:disable-next-line:no-function-expression
       process.stderr.write = function (text: string | Buffer): boolean {
         if (text.toString()) {
           wroteToStdErr = true;
diff --git a/core-build/gulp-core-build/src/test/index.test.ts b/core-build/gulp-core-build/src/test/index.test.ts
@@ -13,8 +13,6 @@ import {
 } from '../index';
 import { mockBuildConfig } from './mockBuildConfig';
 
-/* tslint:disable:no-unused-expression */
-
 // disable the exit watching
 global['dontWatchExit'] = true; // eslint-disable-line dot-notation
 
diff --git a/core-build/gulp-core-build/src/utilities/test/FileDeletionUtility.test.ts b/core-build/gulp-core-build/src/utilities/test/FileDeletionUtility.test.ts
@@ -7,7 +7,6 @@ import { FileDeletionUtility } from './../FileDeletionUtility';
 describe('FileDeletionUtility', () => {
   describe('constructor', () => {
     it('can be constructed', () => {
-      // tslint:disable-next-line:no-unused-variable
       const test: FileDeletionUtility = new FileDeletionUtility();
       assert.isNotNull(test);
     });
diff --git a/libraries/load-themed-styles/src/index.ts b/libraries/load-themed-styles/src/index.ts
@@ -113,7 +113,6 @@ const _themeState: IThemeState = initializeThemeState();
 /**
  * Matches theming tokens. For example, "[theme: themeSlotName, default: #FFF]" (including the quotes).
  */
-// tslint:disable-next-line:max-line-length
 const _themeTokenRegex: RegExp = /[\'\"]\[theme:\s*(\w+)\s*(?:\,\s*default:\s*([\\"\']?[\.\,\(\)\#\-\s\w]*[\.\,\(\)\#\-\w][\"\']?))?\s*\][\'\"]/g;
 
 const now: () => number =
diff --git a/libraries/node-core-library/src/InternalError.ts b/libraries/node-core-library/src/InternalError.ts
@@ -37,7 +37,6 @@ export class InternalError extends Error {
     super(InternalError._formatMessage(message));
 
     // Manually set the prototype, as we can no longer extend built-in classes like Error, Array, Map, etc.
-    // tslint:disable-next-line:max-line-length
     // https://github.com/microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work
     //
     // Note: the prototype must also be set on any classes which extend this one
diff --git a/libraries/node-core-library/src/PackageJsonLookup.ts b/libraries/node-core-library/src/PackageJsonLookup.ts
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-/* tslint:disable:no-constant-condition */
-
 import * as path from 'path';
 import { JsonFile } from './JsonFile';
 import { IPackageJson, INodePackageJson } from './IPackageJson';
diff --git a/libraries/package-deps-hash/src/test/getPackageDeps.test.ts b/libraries/package-deps-hash/src/test/getPackageDeps.test.ts
@@ -104,7 +104,7 @@ describe('getPackageDeps', () => {
     done();
   });
 
-  it('can handle adding one file', (done) => { // tslint:disable-line
+  it('can handle adding one file', (done) => {
     const tempFilePath: string = path.join(TEST_PROJECT_PATH, 'a.txt');
 
     FileSystem.writeFile(tempFilePath, 'a');
@@ -136,7 +136,7 @@ describe('getPackageDeps', () => {
 
   });
 
-  it('can handle adding two files', (done) => { // tslint:disable-line
+  it('can handle adding two files', (done) => {
     const tempFilePath1: string = path.join(TEST_PROJECT_PATH, 'a.txt');
     const tempFilePath2: string = path.join(TEST_PROJECT_PATH, 'b.txt');
 
diff --git a/libraries/rushell/src/ParseError.ts b/libraries/rushell/src/ParseError.ts
@@ -28,7 +28,6 @@ export class ParseError extends Error {
 
     // Boilerplate for extending a system class
     //
-    // tslint:disable-next-line:max-line-length
     // https://github.com/microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work
     //
     // IMPORTANT: The prototype must also be set on any classes which extend this one
diff --git a/libraries/rushell/src/Parser.ts b/libraries/rushell/src/Parser.ts
@@ -11,8 +11,6 @@ import {
   AstText
 } from './AstNode';
 
-// tslint:disable:no-constant-condition
-
 export class Parser {
   private readonly _tokenizer: Tokenizer;
   private _peekedToken: Token | undefined;
diff --git a/libraries/ts-command-line/src/CommandLineParser.ts b/libraries/ts-command-line/src/CommandLineParser.ts
@@ -30,7 +30,6 @@ export class CommandLineParserExitError extends Error {
     super(message);
 
     // Manually set the prototype, as we can no longer extend built-in classes like Error, Array, Map, etc
-    // tslint:disable-next-line:max-line-length
     // https://github.com/microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work
     //
     // Note: the prototype must also be set on any classes which extend this one
diff --git a/repo-scripts/doc-plugin-rush-stack/src/index.ts b/repo-scripts/doc-plugin-rush-stack/src/index.ts
@@ -4,7 +4,6 @@
 import { IApiDocumenterPluginManifest } from '@microsoft/api-documenter';
 import { RushStackFeature } from './RushStackFeature';
 
-// tslint:disable-next-line:export-name
 export const apiDocumenterPluginManifest: IApiDocumenterPluginManifest = {
   manifestVersion: 1000,
   features: [
diff --git a/repo-scripts/repo-toolbox/src/start.ts b/repo-scripts/repo-toolbox/src/start.ts
@@ -6,4 +6,4 @@ import { ToolboxCommandLine } from './ToolboxCommandLine';
 console.log('repo-toolbox\n');
 
 const commandLine: ToolboxCommandLine = new ToolboxCommandLine();
-commandLine.execute(); // tslint:disable-line:no-floating-promises
+commandLine.execute();
diff --git a/webpack/loader-load-themed-styles/src/index.ts b/webpack/loader-load-themed-styles/src/index.ts
@@ -3,4 +3,4 @@
 
 import { LoadThemedStylesLoader } from './LoadThemedStylesLoader';
 
-export = LoadThemedStylesLoader; // tslint:disable-line:export-name
+export = LoadThemedStylesLoader;
diff --git a/webpack/loader-load-themed-styles/src/test/testData/MockStyle2.ts b/webpack/loader-load-themed-styles/src/test/testData/MockStyle2.ts
@@ -1,6 +1,4 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-/* tslint:disable:export-name */
 export = 'styles';
-/* tslint:enable:export-name */
diff --git a/webpack/loader-set-webpack-public-path/src/index.ts b/webpack/loader-set-webpack-public-path/src/index.ts
@@ -3,6 +3,4 @@
 
 import { SetWebpackPublicPathLoader } from './SetWebpackPublicPathLoader';
 
-/* tslint:disable:export-name */
 export = SetWebpackPublicPathLoader;
-/* tslint:enable:export-name */

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ export class ApiItem {`
`231`	`231`	`// These functional forms don't have a proper name, so we don't append the "()" suffix`
`232`	`232`	`break;`
`233`	`233`	`default:`
`234`		`- if (ApiParameterListMixin.isBaseClassOf(current)) { // tslint:disable-line:no-use-before-declare`
	`234`	`+ if (ApiParameterListMixin.isBaseClassOf(current)) {`
`235`	`235`	`reversedParts.push('()');`
`236`	`236`	`}`
`237`	`237`	`}`
Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,6 @@ export class AstSymbolTable {`
`379`	`379`	`return referencedAstEntity;`
`380`	`380`	`}`
`381`	`381`
`382`		`- // tslint:disable-next-line:no-unused-variable`
`383`	`382`	`private _fetchAstDeclaration(node: ts.Node, isExternal: boolean): AstDeclaration \| undefined {`
`384`	`383`	`if (!AstDeclaration.isSupportedSyntaxKind(node.kind)) {`
`385`	`384`	`return undefined;`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,6 @@ export class DtsRollupGenerator {`
`71`	`71`
`72`	`72`	`// Emit the triple slash directives`
`73`	`73`	`for (const typeDirectiveReference of collector.dtsTypeReferenceDirectives) {`
`74`		`- // tslint:disable-next-line:max-line-length`
`75`	`74`	`// https://github.com/microsoft/TypeScript/blob/611ebc7aadd7a44a4c0447698bfda9222a78cb66/src/compiler/declarationEmitter.ts#L162`
`76`	`75`	stringWriter.writeLine(`/// <reference types="${typeDirectiveReference}" />`);
`77`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,6 @@ export class TaskSelector {`
`203`	`203`	`const script: string \| undefined = this._getScriptCommand(rushProject, this._options.commandToRun);`
`204`	`204`
`205`	`205`	`if (script === undefined && !this._options.ignoreMissingScript) {`
`206`		`- // tslint:disable-next-line:max-line-length`
`207`	`206`	throw new Error(`The project [${rushProject.packageName}] does not define a '${this._options.commandToRun}' command in the 'scripts' section of its package.json`);
`208`	`207`	`}`
`209`	`208`