2014-01-10 Mark Hahnenberg <[email protected]>

Copying should be generational

https://bugs.webkit.org/show_bug.cgi?id=126555

Reviewed by Geoffrey Garen.

This patch adds support for copying to our generational collector. Eden collections

always trigger copying. Full collections use our normal fragmentation-based heuristics.

The way this works is that the CopiedSpace now has the notion of an old generation set of CopiedBlocks

and a new generation of CopiedBlocks. During each mutator cycle new CopiedSpace allocations reside

in the new generation. When a collection occurs, those blocks are moved to the old generation.

One key thing to remember is that both new and old generation objects in the MarkedSpace can

refer to old or new generation allocations in CopiedSpace. This is why we must fire write barriers

when assigning to an old (MarkedSpace) object's Butterfly.

* heap/CopiedAllocator.h:

(JSC::CopiedAllocator::tryAllocateDuringCopying):

* heap/CopiedBlock.h:

(JSC::CopiedBlock::CopiedBlock):

(JSC::CopiedBlock::didEvacuateBytes):

(JSC::CopiedBlock::isOld):

(JSC::CopiedBlock::didPromote):

* heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

(JSC::CopiedBlock::reportLiveBytesDuringCopying):

* heap/CopiedSpace.cpp:

(JSC::CopiedSpace::CopiedSpace):

(JSC::CopiedSpace::~CopiedSpace):

(JSC::CopiedSpace::init):

(JSC::CopiedSpace::tryAllocateOversize):

(JSC::CopiedSpace::tryReallocateOversize):

(JSC::CopiedSpace::doneFillingBlock):

(JSC::CopiedSpace::didStartFullCollection):

(JSC::CopiedSpace::doneCopying):

(JSC::CopiedSpace::size):

(JSC::CopiedSpace::capacity):

(JSC::CopiedSpace::isPagedOut):

* heap/CopiedSpace.h:

(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):

* heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::contains):

(JSC::CopiedSpace::recycleEvacuatedBlock):

(JSC::CopiedSpace::allocateBlock):

(JSC::CopiedSpace::startedCopying):

* heap/CopyVisitor.cpp:

(JSC::CopyVisitor::copyFromShared):

* heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::allocateNewSpace):

(JSC::CopyVisitor::allocateNewSpaceSlow):

* heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::didStartCopying):

* heap/Heap.cpp:

(JSC::Heap::copyBackingStores):

* heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

* heap/TinyBloomFilter.h:

(JSC::TinyBloomFilter::add):

2014-01-14 Mark Lam <[email protected]>

ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().

https://bugs.webkit.org/show_bug.cgi?id=126990.

Reviewed by Geoffrey Garen.

* parser/Parser.cpp:

(JSC::Parser<LexerType>::parseConstDeclarationList):

- We were missing an error check after attempting to parse an initializer

expression. This is now fixed.

2014-01-14 Joseph Pecoraro <[email protected]>

Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess

https://bugs.webkit.org/show_bug.cgi?id=126995

Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::listingForDebuggable):

For each WebView, list the parent process. Listing the parent per WebView

is already supported back when we supported processes that could host WebViews

for multiple applications.

* inspector/remote/RemoteInspectorConstants.h:

Add a separate key for the bundle identifier, separate from application identifier.

* inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::info):

* inspector/remote/RemoteInspectorDebuggable.h:

(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):

(Inspector::RemoteInspectorDebuggableInfo::hasParentProcess):

If a RemoteInspectorDebuggable has a non-zero parent process identifier

it is a proxy for the parent process.

2014-01-14 Brian J. Burg <[email protected]>

Add ENABLE(WEB_REPLAY) feature flag to the build system

https://bugs.webkit.org/show_bug.cgi?id=126949

Reviewed by Joseph Pecoraro.

* Configurations/FeatureDefines.xcconfig:

2014-01-14 Peter Molnar <[email protected]>

[EFL] FTL buildfix, add missing includes

https://bugs.webkit.org/show_bug.cgi?id=126641

Reviewed by Csaba Osztrogonác.

* ftl/FTLOSREntry.cpp:

* ftl/FTLOSRExitCompiler.cpp:

2014-01-14 Joseph Pecoraro <[email protected]>

Web Inspector: RemoteInspector::updateDebuggable may miss a push

https://bugs.webkit.org/show_bug.cgi?id=126965

Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::updateDebuggable):

Always push an update. If a debuggable went from allowed to

not allowed, we would have missed pushing an update.

2014-01-13 Mark Hahnenberg <[email protected]>

Performance regression on dromaeo due to generational marking

https://bugs.webkit.org/show_bug.cgi?id=126901

Reviewed by Oliver Hunt.

We were seeing some performance regression with ENABLE_GGC == 0, so this patch

ifdefs out more things to get rid of the additional overhead.

* heap/Heap.cpp:

(JSC::Heap::markRoots):

(JSC::Heap::writeBarrier):

* heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):

(JSC::MarkedBlock::clearMarksWithCollectionType):

* heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):

* heap/MarkedSpace.h:

(JSC::MarkedSpace::didAllocateInBlock):

* heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):

(JSC::SlotVisitor::reportExtraMemoryUsage):

2014-01-13 Brian Burg <[email protected]>

Web Inspector: protocol generator should support integer-typed declarations

https://bugs.webkit.org/show_bug.cgi?id=126828

Reviewed by Joseph Pecoraro.

Add new binding classes for parameter/ad-hoc and normal integer type declarations.

* inspector/scripts/CodeGeneratorInspector.py:

(TypeBindings.create_type_declaration_):

(TypeBindings.create_type_declaration_.PlainInteger):

(TypeBindings.create_type_declaration_.PlainInteger.resolve_inner):

(TypeBindings.create_type_declaration_.PlainInteger.request_user_runtime_cast):

(TypeBindings.create_type_declaration_.PlainInteger.request_internal_runtime_cast):

(TypeBindings.create_type_declaration_.PlainInteger.get_code_generator):

(TypeBindings.create_type_declaration_.PlainInteger.get_validator_call_text):

(TypeBindings.create_type_declaration_.PlainInteger.reduce_to_raw_type):

(TypeBindings.create_type_declaration_.PlainInteger.get_type_model):

(TypeBindings.create_type_declaration_.PlainInteger.get_setter_value_expression_pattern):

(TypeBindings.create_type_declaration_.PlainInteger.get_array_item_c_type_text):

(TypeBindings.create_type_declaration_.TypedefInteger):

(TypeBindings.create_type_declaration_.TypedefInteger.resolve_inner):

(TypeBindings.create_type_declaration_.TypedefInteger.request_user_runtime_cast):

(TypeBindings.create_type_declaration_.TypedefInteger.request_internal_runtime_cast):

(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator):

(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator):

(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder):

(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder.int):

(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.register_use):

(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.get_generate_pass_id):

(TypeBindings.create_type_declaration_.TypedefInteger.get_validator_call_text):

(TypeBindings.create_type_declaration_.TypedefInteger.reduce_to_raw_type):

(TypeBindings.create_type_declaration_.TypedefInteger.get_type_model):

(TypeBindings.create_type_declaration_.TypedefInteger.get_setter_value_expression_pattern):

(TypeBindings.create_type_declaration_.TypedefInteger.get_array_item_c_type_text):

2014-01-13 Zalan Bujtas <[email protected]>

Enable SUBPIXEL_LAYOUT on Mac

<https://webkit.org/b/126283>

Reviewed by Simon Fraser.

* Configurations/FeatureDefines.xcconfig:

2014-01-13 Zan Dobersek <[email protected]>

Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive

is not inserted early enough into the generated assembler code when building in debug mode, causing

compilation failures on ports using the GCC compilers. To work around the problem, only utilize the

OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.

* llint/LowLevelInterpreter.cpp:

2014-01-12 Commit Queue <[email protected]>

Unreviewed, rolling out r161840.

http://trac.webkit.org/changeset/161840

https://bugs.webkit.org/show_bug.cgi?id=126870

Caused jsscore and layout test failures (Requested by smfr on

#webkit).

* API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

* bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue):

* inspector/InspectorValues.cpp:

* runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

* runtime/Identifier.h:

(JSC::Identifier::characters):

* runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append):

2014-01-12 Darin Adler <[email protected]>

Add deprecatedCharacters as a synonym for characters and convert most call sites

https://bugs.webkit.org/show_bug.cgi?id=126858

Reviewed by Anders Carlsson.

* API/JSStringRef.cpp:

(JSStringGetCharactersPtr):

(JSStringGetUTF8CString):

(JSStringIsEqual):

* API/JSStringRefCF.cpp:

(JSStringCopyCFString):

* API/OpaqueJSString.h:

(OpaqueJSString::characters):

(OpaqueJSString::deprecatedCharacters):

(OpaqueJSString::length):

(OpaqueJSString::OpaqueJSString):

* inspector/InspectorValues.cpp:

(Inspector::InspectorValue::parseJSON):

* runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):

* runtime/StringPrototype.cpp:

(JSC::localeCompare):

(JSC::stringProtoFuncFontsize):

(JSC::stringProtoFuncLink):

Use deprecatedCharacters instead of characters.

2014-01-12 Darin Adler <[email protected]>

Reduce use of String::characters

https://bugs.webkit.org/show_bug.cgi?id=126854

Reviewed by Sam Weinig.

* API/JSValueRef.cpp:

(JSValueMakeFromJSONString): Use characters16 instead of characters for 16-bit case.

Had to remove length check because an empty string could be either 8 bit or 16 bit.

Don't need a null string check before calling is8Bit because JSStringRef can't hold

a null string.

* bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue): Use the existing string here instead of creating

a new one by calling characters and length on the old string. I think this may be

left over from when string types were not the same in JavaScriptCore and WebCore.

Also rewrite the property names loop to use modern for syntax and fewer locals.

* inspector/InspectorValues.cpp:

(Inspector::escapeChar): Changed to use appendLiteral instead of hard-coding string

lengths. Moved handling of "<" and ">" in here instead of at the call site.

(Inspector::doubleQuoteString): Simplify the code so there is no use of characters

and length. This is still an inefficient way of doing this job and could use a rethink.

* runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Use RetainPtr, createCFString, and the conversion from

CFStringRef to WTF::String to remove a lot of unneeded code.

* runtime/Identifier.h: Removed unneeded Identifier::characters function.

* runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append): Use characters16 instead of characters function here,

since we have already checked is8Bit above.

2014-01-12 Andy Estes <[email protected]>

[iOS] Enable the JSC Objective-C API

Rubber-stamped by Simon Fraser.

* API/JSBase.h:

2014-01-12 Carlos Garcia Campos <[email protected]>

Unreviewed. Fix make distcheck.

* GNUmakefile.am: Add inline-and-minify-stylesheets-and-scripts.py

to EXTRA_DIST and fix InjectedScriptSource.h generation rule.

* GNUmakefile.list.am: Move InjectedScriptSource.h to

built_nosources to make sure it's not disted.

2014-01-11 Anders Carlsson <[email protected]>

Try again to fix the build.

* inspector/InspectorAgentRegistry.cpp:

* inspector/InspectorAgentRegistry.h:

2014-01-11 Anders Carlsson <[email protected]>

Try to prevent the Vector copy constructor from being instantiated.

* inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):

* inspector/InspectorAgentRegistry.h:

2014-01-11 Anders Carlsson <[email protected]>

Try something else.

* inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::~InspectorAgentRegistry):

* inspector/InspectorAgentRegistry.h:

2014-01-11 Dean Jackson <[email protected]>

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification

https://bugs.webkit.org/show_bug.cgi?id=126754

Reviewed by Filip Pizlo.

The ECMAScript specification forbids calling the typed array

constructors without using "new". Change the call data to return

none so we throw and exception in these cases.

* runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

2014-01-11 Anders Carlsson <[email protected]>

Try to fix the build by introducing a constructor.

* inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):

* inspector/InspectorAgentRegistry.h:

2014-01-11 Anders Carlsson <[email protected]>

* inspector/InspectorAgentRegistry.h:

Remove an unused function.

2014-01-11 Anders Carlsson <[email protected]>

InspectorAgentRegistry should use std::unique_ptr

https://bugs.webkit.org/show_bug.cgi?id=126826

Reviewed by Sam Weinig.

* inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::append):

* inspector/InspectorAgentRegistry.h:

* inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

* inspector/agents/InspectorAgent.h:

2014-01-10 Joseph Pecoraro <[email protected]>

Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController

https://bugs.webkit.org/show_bug.cgi?id=126763

Reviewed by Timothy Hatcher.

Introduce JSGlobalObjectInspectorController. This is the InspectorController

for a JSContext. It is created by the JSGlobalObject Remote Inspector Debuggable

when a remote frontend connects, and is destroyed when the remote frontend

disconnects of the JSGlobalObject is destroyed.

* inspector/JSGlobalObjectInspectorController.h: Added.

* inspector/JSGlobalObjectInspectorController.cpp: Added.

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):

(Inspector::JSGlobalObjectInspectorController::connectFrontend):

(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):

(Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend):

(Inspector::JSGlobalObjectInspectorController::functionCallHandler):

(Inspector::JSGlobalObjectInspectorController::evaluateHandler):

Create/destory agents, create/destroy dispatches, implement InspectorEnvironment.

* runtime/JSGlobalObjectDebuggable.h:

* runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::~JSGlobalObjectDebuggable):

(JSC::JSGlobalObjectDebuggable::connect):

(JSC::JSGlobalObjectDebuggable::disconnect):

(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):

Forward actions to the InspectorController object.

* inspector/agents/InspectorAgent.h: Renamed from Source/WebCore/inspector/InspectorAgent.h.

* inspector/agents/InspectorAgent.cpp: Renamed from Source/WebCore/inspector/InspectorAgent.cpp.

(Inspector::InspectorAgent::InspectorAgent):

(Inspector::InspectorAgent::~InspectorAgent):

(Inspector::InspectorAgent::didCreateFrontendAndBackend):

(Inspector::InspectorAgent::inspect):

(Inspector::InspectorAgent::evaluateForTestInFrontend):

Implement InspectorAgent in JavaScriptCore in namespace Inspector.

* JavaScriptCore.xcodeproj/project.pbxproj:

* CMakeLists.txt:

* ChangeLog:

* GNUmakefile.am:

* GNUmakefile.list.am:

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:

* JavaScriptCore.vcxproj/copy-files.cmd:

Add files and new inspector/agents subdirectory.

2014-01-10 Commit Queue <[email protected]>

Unreviewed, rolling out r161702.

http://trac.webkit.org/changeset/161702

https://bugs.webkit.org/show_bug.cgi?id=126803

Broke multiple tests (Requested by ap on #webkit).

* runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

2014-01-10 David Kilzer <[email protected]>

Clean up architectures in xcconfig files

<http://webkit.org/b/126794>

Reviewed by Andy Estes.

* Configurations/Base.xcconfig:

* Configurations/JavaScriptCore.xcconfig: Remove armv6, ppc.

* Configurations/ToolExecutable.xcconfig: Sort.

- Add new arch.

2014-01-10 Dean Jackson <[email protected]>

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification

https://bugs.webkit.org/show_bug.cgi?id=126754

Reviewed by Filip Pizlo.

The ECMAScript specification forbids calling the typed array

constructors without using "new". Change the call data to return

none so we throw and exception in these cases.

* runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

2014-01-10 Benjamin Poulain <[email protected]>

Remove the BlackBerry port from trunk

https://bugs.webkit.org/show_bug.cgi?id=126715

Reviewed by Anders Carlsson.

* assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

* assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::replaceWithJump):

(JSC::ARMv7Assembler::maxJumpReplacementSize):

(JSC::ARMv7Assembler::cacheFlush):

* assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

* heap/MachineStackMarker.cpp:

(JSC::getPlatformThreadRegisters):

(JSC::otherThreadStackPointer):

(JSC::freePlatformThreadRegisters):

* jit/ExecutableAllocator.h:

2014-01-10 Joseph Pecoraro <[email protected]>

Web Inspector: Remove unimplemented or static ScriptDebugServer features

https://bugs.webkit.org/show_bug.cgi?id=126784

Reviewed by Timothy Hatcher.

* inspector/protocol/Debugger.json:

2014-01-10 Michael Saboff <[email protected]>

REGRESSION(C stack work): stack traces no longer work in CrashTracer, lldb, and other tools

https://bugs.webkit.org/show_bug.cgi?id=126764

Reviewed by Geoffrey Garen.

Updated callToJavaScript and cllToNativeFunction to properly replicate the caller's

return PC and frame pointer in the sentinel frame. For X86-64, added .cfi_

directives to create eh_frame info for all LLInt symbols so that the various

unwinding code understands that we are using a separate JS stack referenced

by BP and at what offsets in that frame the prior PC (register 16) and prior

BP (register 6) can be found. These two changes are sufficient for stack tracing

to work for Mac OSX.

* llint/LowLevelInterpreter.cpp:

* llint/LowLevelInterpreter64.asm:

2014-01-10 Tamas Gergely <[email protected]>

[EFL][JSC] Enable udis86 disassembler on efl.

https://bugs.webkit.org/show_bug.cgi?id=125502

Reviewed by Michael Saboff.

Enable udis86 disassembler on efl and fix build warnings.

* CMakeLists.txt:

Add udis86 disassembler source files.

* disassembler/udis86/udis86_decode.c:

(decode_modrm_rm):

Build warning fixes.

* disassembler/udis86/udis86_syn-att.c:

(gen_operand):

Build warning fixes.

* disassembler/udis86/udis86_syn-intel.c:

(gen_operand):

Build warning fixes.

* disassembler/udis86/udis86_types.h:

Correct FMT64 for uint64_t.

2014-01-09 Benjamin Poulain <[email protected]>

Remove the BlackBerry files outside WebCore

https://bugs.webkit.org/show_bug.cgi?id=126715

Reviewed by Anders Carlsson.

* PlatformBlackBerry.cmake: Removed.

* runtime/GCActivityCallbackBlackBerry.cpp: Removed.

* shell/PlatformBlackBerry.cmake: Removed.

2014-01-10 Geoffrey Garen <[email protected]>

Removed Blackberry #ifdefs and platform code from JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=126757

Reviewed by Sam Weinig.

* PlatformBlackBerry.cmake: Removed.

* heap/HeapTimer.cpp:

* heap/HeapTimer.h:

* heap/IncrementalSweeper.cpp:

* heap/IncrementalSweeper.h:

* jsc.cpp:

(main):

* runtime/GCActivityCallbackBlackBerry.cpp: Removed.

* runtime/MemoryStatistics.cpp:

(JSC::globalMemoryStatistics):

2014-01-07 Mark Hahnenberg <[email protected]>

Marking should be generational

https://bugs.webkit.org/show_bug.cgi?id=126552

Reviewed by Geoffrey Garen.

Re-marking the same objects over and over is a waste of effort. This patch implements

the sticky mark bit algorithm (along with our already-present write barriers) to reduce

overhead during garbage collection caused by rescanning objects.

There are now two collection modes, EdenCollection and FullCollection. EdenCollections

only visit new objects or objects that were added to the remembered set by a write barrier.

FullCollections are normal collections that visit all objects regardless of their

generation.

In this patch EdenCollections do not do anything in CopiedSpace. This will be fixed in

https://bugs.webkit.org/show_bug.cgi?id=126555.

* bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

* bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

* dfg/DFGOperations.cpp:

* heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::add):

(JSC::CodeBlockSet::traceMarked):

(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):

* heap/CodeBlockSet.h:

* heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

* heap/CopiedSpace.cpp:

(JSC::CopiedSpace::didStartFullCollection):

* heap/CopiedSpace.h:

(JSC::CopiedSpace::heap):

* heap/Heap.cpp:

(JSC::Heap::Heap):

(JSC::Heap::didAbandon):

(JSC::Heap::markRoots):

(JSC::Heap::copyBackingStores):

(JSC::Heap::addToRememberedSet):

(JSC::Heap::collectAllGarbage):

(JSC::Heap::collect):

(JSC::Heap::didAllocate):

(JSC::Heap::writeBarrier):

* heap/Heap.h:

(JSC::Heap::isInRememberedSet):

(JSC::Heap::operationInProgress):

(JSC::Heap::shouldCollect):

(JSC::Heap::isCollecting):

(JSC::Heap::isWriteBarrierEnabled):

(JSC::Heap::writeBarrier):

* heap/HeapOperation.h:

* heap/MarkStack.cpp:

(JSC::MarkStackArray::~MarkStackArray):

(JSC::MarkStackArray::clear):

(JSC::MarkStackArray::fillVector):

* heap/MarkStack.h:

* heap/MarkedAllocator.cpp:

(JSC::isListPagedOut):

(JSC::MarkedAllocator::isPagedOut):

(JSC::MarkedAllocator::tryAllocateHelper):

(JSC::MarkedAllocator::addBlock):

(JSC::MarkedAllocator::removeBlock):

(JSC::MarkedAllocator::reset):

* heap/MarkedAllocator.h:

(JSC::MarkedAllocator::MarkedAllocator):

* heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):

(JSC::MarkedBlock::clearRememberedSet):

(JSC::MarkedBlock::clearMarksWithCollectionType):

(JSC::MarkedBlock::lastChanceToFinalize):

* heap/MarkedBlock.h: Changed atomSize to 16 bytes because we have no objects smaller

than 16 bytes. This is also to pay for the additional Bitmap for the remembered set.

(JSC::MarkedBlock::didConsumeEmptyFreeList):

(JSC::MarkedBlock::setRemembered):

(JSC::MarkedBlock::clearRemembered):

(JSC::MarkedBlock::atomicClearRemembered):

(JSC::MarkedBlock::isRemembered):

* heap/MarkedSpace.cpp:

(JSC::MarkedSpace::~MarkedSpace):

(JSC::MarkedSpace::resetAllocators):

(JSC::MarkedSpace::visitWeakSets):

(JSC::MarkedSpace::reapWeakSets):

(JSC::VerifyMarked::operator()):

(JSC::MarkedSpace::clearMarks):

* heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):

(JSC::ClearRememberedSet::operator()):

(JSC::MarkedSpace::didAllocateInBlock):

(JSC::MarkedSpace::clearRememberedSet):

* heap/SlotVisitor.cpp:

(JSC::SlotVisitor::~SlotVisitor):

(JSC::SlotVisitor::clearMarkStack):

* heap/SlotVisitor.h:

(JSC::SlotVisitor::markStack):

(JSC::SlotVisitor::sharedData):

* heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):

(JSC::SlotVisitor::unconditionallyAppend):

(JSC::SlotVisitor::copyLater):

(JSC::SlotVisitor::reportExtraMemoryUsage):

(JSC::SlotVisitor::heap):

* jit/Repatch.cpp:

* runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

* runtime/JSPropertyNameIterator.h:

(JSC::StructureRareData::setEnumerationCache):

* runtime/JSString.cpp:

(JSC::JSString::visitChildren):

* runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setPreviousID):

(JSC::StructureRareData::setObjectToStringValue):

* runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren):

2014-01-09 Joseph Pecoraro <[email protected]>

Unreviewed Windows build fix for r161563.

Copy all scripts, some may not be .py.

* JavaScriptCore.vcxproj/copy-files.cmd:

2014-01-09 Filip Pizlo <[email protected]>

AI for CreateArguments should pass through non-SpecEmpty input values

https://bugs.webkit.org/show_bug.cgi?id=126709

Reviewed by Mark Hahnenberg.

* dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

* tests/stress/use-arguments-as-object-pointer.js: Added.

(foo):

2014-01-09 Mark Hahnenberg <[email protected]>

Constructors for Objective-C classes do not work properly with instanceof

https://bugs.webkit.org/show_bug.cgi?id=126670

Reviewed by Oliver Hunt.

This bug is due to the fact that the JS constructors created for Objective-C classes via the JSC

API inherit from JSCallbackObject, which overrides hasInstance with its own customHasInstance.

JSCallbackObject::customHasInstance only checks the JSClassRefs for hasInstance callbacks.

If it doesn't find any callbacks, it returns false.

This patch adds a hasInstance callback to constructors created for Objective-C wrapper classes.

* API/JSWrapperMap.mm:

(constructorHasInstance):

(constructorWithCustomBrand):

(allocateConstructorForCustomClass):

* API/tests/testapi.mm:

2014-01-09 Joseph Pecoraro <[email protected]>

Web Inspector: Move InjectedScript classes into JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=126598

Reviewed by Timothy Hatcher.

Part 5: Move InjectedScript classes into JavaScriptCore

There are pieces of logic that WebCore wants to hook into in the InjectedScript

execution (e.g. for CommandLineAPIModule and InspectorInstrumentation). Create

hooks for those in a base class called InspectorEnvironment. For now, the

InspectorControllers (Page, JSGlobalObject, Worker) will be the InspectorEnvironments

and provide answers to its hooks.

* inspector/InspectorEnvironment.h: Added.

New hooks needed by WebCore in various places. Mostly stubbed in JavaScriptCore.

* inspector/InjectedScript.cpp: Renamed from Source/WebCore/inspector/InjectedScript.cpp.

* inspector/InjectedScript.h: Added.

* inspector/InjectedScriptBase.cpp: Renamed from Source/WebCore/inspector/InjectedScriptBase.cpp.

* inspector/InjectedScriptBase.h: Renamed from Source/WebCore/inspector/InjectedScriptBase.h.

* inspector/InjectedScriptModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptModule.cpp.

* inspector/InjectedScriptModule.h: Renamed from Source/WebCore/inspector/InjectedScriptModule.h.

Cleanup the style of these files (nullptr, formatting, whitespace, etc).

Use the InspectorEnvironments call/evaluate function for ScriptFunctionCalls and checking access

* inspector/InjectedScriptManager.cpp: Renamed from Source/WebCore/inspector/InjectedScriptManager.cpp.

* inspector/InjectedScriptManager.h: Renamed from Source/WebCore/inspector/InjectedScriptManager.h.

Take an InspectorEnvironment with multiple hooks, instead of a single hook function.

* inspector/InjectedScriptHost.cpp: Added.

* inspector/InjectedScriptHost.h: Added.

* inspector/JSInjectedScriptHost.cpp: Renamed from Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp.

* inspector/JSInjectedScriptHost.h: Added.

* inspector/JSInjectedScriptHostPrototype.cpp: Added.

* inspector/JSInjectedScriptHostPrototype.h: Added.

Implementation of InjectedScriptHost which is passed into the script (InjectedScriptSource.js)

that we inject into the page. This is mostly copied from the original autogenerated code,

then simplified and cleaned up. InjectedScriptHost can be subclasses to provide specialized

implementations of isHTMLAllCollection and type for Web/DOM types unknown to a pure JS context.

Part 4: Move all inspector scripts into JavaScriptCore and update generators.

For OS X be sure to export the scripts as if they are private headers.

* GNUmakefile.am:

* JavaScriptCore.xcodeproj/project.pbxproj:

* inspector/scripts/cssmin.py: Renamed from Source/WebCore/inspector/Scripts/cssmin.py.

* inspector/scripts/inline-and-minify-stylesheets-and-scripts.py: Renamed from Source/WebCore/inspector/Scripts/inline-and-minify-stylesheets-and-scripts.py.

* inspector/scripts/jsmin.py: Renamed from Source/WebCore/inspector/Scripts/jsmin.py.

* inspector/scripts/xxd.pl: Renamed from Source/WebCore/inspector/xxd.pl.

Part 3: Update CodeGeneratorInspector to avoid inlining virtual destructors.

This avoids build errors about duplicate exported virtual inlined methods

are included from multiple places. Just put empty destructors in the

implementation file instead of inlined.

* inspector/scripts/CodeGeneratorInspector.py:

(Generator):

(Generator.go):

* inspector/scripts/CodeGeneratorInspectorStrings.py:

Part 2: Move InjectedScriptSource and generation into JavaScriptCore.

Move InjectedScriptSource.js and derived sources generation.

* CMakeLists.txt:

* DerivedSources.make:

* GNUmakefile.am:

* GNUmakefile.list.am:

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:

* JavaScriptCore.xcodeproj/project.pbxproj:

* inspector/InjectedScriptSource.js: Renamed from Source/WebCore/inspector/InjectedScriptSource.js.

2014-01-09 Balazs Kilvady <[email protected]>

Regression: failing RegExp tests on 32 bit architectures.

https://bugs.webkit.org/show_bug.cgi?id=126699

Reviewed by Michael Saboff.

Fix setRegExpConstructor functions for 32 bit architectures.

* runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorInput):

(JSC::setRegExpConstructorMultiline):

2014-01-09 Commit Queue <[email protected]>

Unreviewed, rolling out r161540.

http://trac.webkit.org/changeset/161540

https://bugs.webkit.org/show_bug.cgi?id=126704

Caused assertion failures on multiple tests (Requested by ap

on #webkit).

* bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

* bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

* dfg/DFGOperations.cpp:

* heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::add):

(JSC::CodeBlockSet::traceMarked):

* heap/CodeBlockSet.h:

* heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

* heap/CopiedSpace.cpp:

* heap/CopiedSpace.h:

* heap/Heap.cpp:

(JSC::Heap::Heap):

(JSC::Heap::didAbandon):

(JSC::Heap::markRoots):

(JSC::Heap::copyBackingStores):

(JSC::Heap::collectAllGarbage):

(JSC::Heap::collect):

(JSC::Heap::didAllocate):

* heap/Heap.h:

(JSC::Heap::shouldCollect):

(JSC::Heap::isCollecting):

(JSC::Heap::isWriteBarrierEnabled):

(JSC::Heap::writeBarrier):

* heap/HeapOperation.h:

* heap/MarkStack.cpp:

(JSC::MarkStackArray::~MarkStackArray):

* heap/MarkStack.h:

* heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::isPagedOut):

(JSC::MarkedAllocator::tryAllocateHelper):

(JSC::MarkedAllocator::addBlock):

(JSC::MarkedAllocator::removeBlock):

* heap/MarkedAllocator.h:

(JSC::MarkedAllocator::MarkedAllocator):

(JSC::MarkedAllocator::reset):

* heap/MarkedBlock.cpp:

* heap/MarkedBlock.h:

(JSC::MarkedBlock::lastChanceToFinalize):

(JSC::MarkedBlock::didConsumeEmptyFreeList):

(JSC::MarkedBlock::clearMarks):

* heap/MarkedSpace.cpp:

(JSC::MarkedSpace::~MarkedSpace):

(JSC::MarkedSpace::resetAllocators):

(JSC::MarkedSpace::visitWeakSets):

(JSC::MarkedSpace::reapWeakSets):

* heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):

(JSC::MarkedSpace::clearMarks):

* heap/SlotVisitor.cpp:

(JSC::SlotVisitor::~SlotVisitor):

* heap/SlotVisitor.h:

(JSC::SlotVisitor::sharedData):

* heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):

(JSC::SlotVisitor::copyLater):

(JSC::SlotVisitor::reportExtraMemoryUsage):

* jit/Repatch.cpp:

* runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

* runtime/JSPropertyNameIterator.h:

(JSC::StructureRareData::setEnumerationCache):

* runtime/JSString.cpp:

(JSC::JSString::visitChildren):

* runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setPreviousID):

(JSC::StructureRareData::setObjectToStringValue):

* runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren):

2014-01-09 Andreas Kling <[email protected]>

Shrink WatchpointSet.

<https://webkit.org/b/126694>

Reorder the members of WatchpointSet, shrinking it by 8 bytes.

767 kB progression on Membuster3.

Reviewed by Antti Koivisto.

* bytecode/Watchpoint.h:

2014-01-08 Mark Hahnenberg <[email protected]>

Reverting accidental GC logging

* heap/Heap.cpp:

2014-01-07 Mark Hahnenberg <[email protected]>

Marking should be generational

https://bugs.webkit.org/show_bug.cgi?id=126552

Reviewed by Geoffrey Garen.

Re-marking the same objects over and over is a waste of effort. This patch implements

the sticky mark bit algorithm (along with our already-present write barriers) to reduce

overhead during garbage collection caused by rescanning objects.

There are now two collection modes, EdenCollection and FullCollection. EdenCollections

only visit new objects or objects that were added to the remembered set by a write barrier.

FullCollections are normal collections that visit all objects regardless of their

generation.

In this patch EdenCollections do not do anything in CopiedSpace. This will be fixed in

https://bugs.webkit.org/show_bug.cgi?id=126555.

* bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

* bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

* dfg/DFGOperations.cpp:

* heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::add):

(JSC::CodeBlockSet::traceMarked):

(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):

* heap/CodeBlockSet.h:

* heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

* heap/CopiedSpace.cpp:

(JSC::CopiedSpace::didStartFullCollection):

* heap/CopiedSpace.h:

(JSC::CopiedSpace::heap):

* heap/Heap.cpp:

(JSC::Heap::Heap):

(JSC::Heap::didAbandon):

(JSC::Heap::markRoots):

(JSC::Heap::copyBackingStores):

(JSC::Heap::addToRememberedSet):

(JSC::Heap::collectAllGarbage):

(JSC::Heap::collect):

(JSC::Heap::didAllocate):

(JSC::Heap::writeBarrier):

* heap/Heap.h:

(JSC::Heap::isInRememberedSet):

(JSC::Heap::operationInProgress):

(JSC::Heap::shouldCollect):

(JSC::Heap::isCollecting):

(JSC::Heap::isWriteBarrierEnabled):

(JSC::Heap::writeBarrier):

* heap/HeapOperation.h:

* heap/MarkStack.cpp:

(JSC::MarkStackArray::~MarkStackArray):

(JSC::MarkStackArray::clear):

(JSC::MarkStackArray::fillVector):

* heap/MarkStack.h:

* heap/MarkedAllocator.cpp:

(JSC::isListPagedOut):

(JSC::MarkedAllocator::isPagedOut):

(JSC::MarkedAllocator::tryAllocateHelper):

(JSC::MarkedAllocator::addBlock):

(JSC::MarkedAllocator::removeBlock):

(JSC::MarkedAllocator::reset):

* heap/MarkedAllocator.h:

(JSC::MarkedAllocator::MarkedAllocator):

* heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):

(JSC::MarkedBlock::clearRememberedSet):

(JSC::MarkedBlock::clearMarksWithCollectionType):

(JSC::MarkedBlock::lastChanceToFinalize):

* heap/MarkedBlock.h: Changed atomSize to 16 bytes because we have no objects smaller

than 16 bytes. This is also to pay for the additional Bitmap for the remembered set.

(JSC::MarkedBlock::didConsumeEmptyFreeList):

(JSC::MarkedBlock::setRemembered):

(JSC::MarkedBlock::clearRemembered):

(JSC::MarkedBlock::atomicClearRemembered):

(JSC::MarkedBlock::isRemembered):

* heap/MarkedSpace.cpp:

(JSC::MarkedSpace::~MarkedSpace):

(JSC::MarkedSpace::resetAllocators):

(JSC::MarkedSpace::visitWeakSets):

(JSC::MarkedSpace::reapWeakSets):

(JSC::VerifyMarked::operator()):

(JSC::MarkedSpace::clearMarks):

* heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):

(JSC::ClearRememberedSet::operator()):

(JSC::MarkedSpace::didAllocateInBlock):

(JSC::MarkedSpace::clearRememberedSet):

* heap/SlotVisitor.cpp:

(JSC::SlotVisitor::~SlotVisitor):