[Update] Refactor, add LoginService interface

Maxron · Maxron · commit 01eaf2ccbde5 · 2019-03-26T23:03:46.000+08:00
diff --git a/src/main/java/EmailLoginService.java b/src/main/java/EmailLoginService.java
@@ -0,0 +1,15 @@
+public class EmailLoginService implements LoginService {
+
+    private final String email;
+    private final String passwd;
+
+    public EmailLoginService(String email, String passwd) {
+        this.email = email;
+        this.passwd = passwd;
+    }
+
+    @Override
+    public void login() {
+        System.out.println("LoginService by email:" + email);
+    }
+}
diff --git a/src/main/java/Example.java b/src/main/java/Example.java
@@ -1,9 +1,13 @@
 public class Example {
     public static void main(String[] args) {
-        LoginView loginView = new LoginView();
-        loginView.login("test@gmailcom", "passwd");
 
-        loginView.loginByPhoneNumber("+886910111222", "passwd");
+        LoginService emailLoginService = new EmailLoginService("test@gmail.com", "passwd");
+        LoginView loginView = new LoginView(emailLoginService);
+        loginView.startLogin();
+
+        LoginService phoneNumberLoginService = new PhoneNumberLoginService("+886910111222", "passwd");
+        loginView = new LoginView(phoneNumberLoginService);
+        loginView.startLogin();
     }
 
 }
diff --git a/src/main/java/LoginService.java b/src/main/java/LoginService.java
@@ -0,0 +1,3 @@
+public interface LoginService {
+    void login();
+}
diff --git a/src/main/java/LoginView.java b/src/main/java/LoginView.java
@@ -1,9 +1,11 @@
 public class LoginView {
-    public void login(String email, String passwd) {
-        System.out.println("Login :" + email);
+    private LoginService loginService;
+
+    public LoginView(LoginService emailLoginService) {
+        this.loginService = emailLoginService;
     }
 
-    public void loginByPhoneNumber(String phoneNumber, String passwd) {
-        System.out.println("Login by phone: " + phoneNumber);
+    public void startLogin() {
+        loginService.login();
     }
 }
diff --git a/src/main/java/PhoneNumberLoginService.java b/src/main/java/PhoneNumberLoginService.java
@@ -0,0 +1,14 @@
+public class PhoneNumberLoginService implements LoginService {
+    private String phonenumber;
+    private String passwd;
+
+    public PhoneNumberLoginService(String phoneNumber, String passwd) {
+        this.phonenumber = phoneNumber;
+        this.passwd = passwd;
+    }
+
+    @Override
+    public void login() {
+        System.out.println("Login by phone number:" + this.phonenumber);
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+public interface LoginService {`
	`2`	`+ void login();`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,11 @@`
`1`	`1`	`public class LoginView {`
`2`		`- public void login(String email, String passwd) {`
`3`		`- System.out.println("Login :" + email);`
	`2`	`+ private LoginService loginService;`
	`3`	`+`
	`4`	`+ public LoginView(LoginService emailLoginService) {`
	`5`	`+ this.loginService = emailLoginService;`
`4`	`6`	`}`
`5`	`7`
`6`		`- public void loginByPhoneNumber(String phoneNumber, String passwd) {`
`7`		`- System.out.println("Login by phone: " + phoneNumber);`
	`8`	`+ public void startLogin() {`
	`9`	`+ loginService.login();`
`8`	`10`	`}`
`9`	`11`	`}`