fix: parse width and height from string to int in ImageAsset options …#10763
Closed
kishore-144 wants to merge 1 commit intoNativeScript:mainfrom
Closed
fix: parse width and height from string to int in ImageAsset options …#10763kishore-144 wants to merge 1 commit intoNativeScript:mainfrom
kishore-144 wants to merge 1 commit intoNativeScript:mainfrom
Conversation
…to avoid JSONException
Author
|
Hi, could a maintainer please approve the workflow and review this PR when possible? Thank you! |
Contributor
We have already got an open PR about this: #10736 |
Author
|
Got it, thanks for clarifying! Since there’s already an open PR for this fix (#10736) and a workaround for now, I’ll close this one to avoid duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix ensures that the width and height options in the ImageAsset class are properly converted from string to integer before being passed to the native image loading utility.
Previously, if these values were provided as strings, it could cause unexpected behavior or errors during image processing on Android.
Added type checks and parsing of width and height in getImageAsync method
Ensured fallback to 0 if parsing fails, maintaining backward compatibility
This resolves issues related to incorrect image sizing and improves robustness in handling image options
Here is the code that i have changed in the getImageAsync function placed in index.android.ts
public getImageAsync(callback: (image, error) => void) {
if (this.options) {
if (typeof this.options.width === 'string') {
this.options.width = parseInt(this.options.width, 10) || 0;
}
if (typeof this.options.height === 'string') {
this.options.height = parseInt(this.options.height, 10) || 0;
}
}