fix(android): coerce string width/height in ImageAssetOptions #6289#10906
Closed
ira-po wants to merge 1 commit intoNativeScript:mainfrom
Closed
fix(android): coerce string width/height in ImageAssetOptions #6289#10906ira-po wants to merge 1 commit intoNativeScript:mainfrom
ira-po wants to merge 1 commit intoNativeScript:mainfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ira Pochaievets.
|
04aba33 to
c42d2c2
Compare
Contributor
|
Hey! Thanks so much for opening a pull request! A prior PR was opened to solve this issue here: #10862 which will be merging. Thanks again, and we look forward to seeing more PRs from you in the future! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #6289, where setting
widthorheightas a string inImageAssetOptionscaused an error on Android (bitmap size exceeds 32 bits).Problem
When
widthorheightwere provided as strings (e.g.,"300"instead of300), the Android code failed to process them correctly, leading to a crash, especially on older API levels (e.g., API 22).How to test
Create an ImageAsset instance with width/height as strings and call getImageAsync.
Before this fix, Android API 22 would crash.
After this fix, the image loads successfully without errors.
Solution
Before passing the options to the native method, this PR checks if
widthorheightare strings and converts them to numbers usingparseInt.