Code Cleanup within derma folder#103
Merged
TovarischPootis merged 5 commits intoNutScript:1.2.3-wipfrom Sep 1, 2022
Merged
Conversation
- Removed Indents from file - Negated if statements and added returns - Removed stupid found logic in animations - Moved SetIK up in run order its not affected by anims - Removed multiple string lowers - Removed unused variable y - Added Check for ik to only disable if valid - Localised double global table index
- Removed adjustSize duplicate code - Removed Action text being duplicated - Renamed fagLord variable to isIconUpdating - Removed unneeded inline comments - Cleaned up if mode fallback (could be cleaned up better with enums and lookup)
- Removed multiple calls to GetWide - Removed unused variables that caused a shadow binding
- Removed code duplication - Removed unneeded code indent - Negated ifs in hook to remove indents - Removed some trailing spaces in cl_dev_icon
- Added a missing return - Removed unneeded indents - Removed unused variable - Added changes to sequence
Contributor
|
2 things
|
Contributor
Author
|
I don't understand the second point. |
Contributor
|
I am a blind troglodyte. My bad. |
TovarischPootis
approved these changes
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the most part just code visibility changes.
Making it easier for people to read the code.
However there are also some very minor optimizations within the code as well.
Along with some unused variables also getting purged.
And a variable name that could be considered offensive was also changed.
I have not been able to test this code.