Fix some items acting as uninteractable watermelons#4
Merged
zoephix merged 2 commits intoNutScript:1.2-wipfrom Feb 14, 2021
TovarischPootis:1.2-wip
Merged
Fix some items acting as uninteractable watermelons#4zoephix merged 2 commits intoNutScript:1.2-wipfrom TovarischPootis:1.2-wip
zoephix merged 2 commits intoNutScript:1.2-wipfrom
TovarischPootis:1.2-wip
Conversation
The issue is that upon item entity spawn, the entity is always set to watermelon as a default. Then, in ENT:setItem, that code is run again, this time with the proper item model. Most of the time that's fine, however some models have funky physics that dont update, causing the model to stay with the watermelon physics, and not not traceable. Here we just set the correct model right away, avoiding that issue
zoephix
reviewed
Feb 14, 2021
entities/entities/nut_item.lua
Outdated
|
|
||
| self:PhysicsInit(SOLID_VPHYSICS) | ||
| self:SetSolid(SOLID_VPHYSICS) | ||
| self:SetModel(model) |
Contributor
There was a problem hiding this comment.
You are setting the model twice
Contributor
Author
There was a problem hiding this comment.
Good catch, fixed
zoephix
added a commit
that referenced
this pull request
Feb 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that upon item entity spawn, the entity is always set to watermelon as a default. Then, in ENT:setItem, that code is run again, this time with the proper item model. Most of the time that's fine, however some models have funky physics that dont update, causing the model to stay with the watermelon physics, and not not traceable. Here we just set the correct model right away, avoiding that issue