Use the OfflinePlayer$getPlayer method instead of casting to Player class#1040
Merged
iGabyTM merged 1 commit intoPlaceholderAPI:masterfrom Mar 7, 2024
DevCyntrix:fix-class-cast-exception
Merged
Use the OfflinePlayer$getPlayer method instead of casting to Player class#1040iGabyTM merged 1 commit intoPlaceholderAPI:masterfrom DevCyntrix:fix-class-cast-exception
iGabyTM merged 1 commit intoPlaceholderAPI:masterfrom
DevCyntrix:fix-class-cast-exception
Conversation
…lass You should use this to avoid a class cast exception if some other plugins uses an own Implementation of the offline player.
iGabyTM
approved these changes
Jan 29, 2024
Andre601
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
Uses the OfflinePlayer$getPlayer method instead of casting to the Player class. That avoids a class cast exception if other plugins uses an own implementation of the offline player class.