Skip to content

Feature/separate compabitility module#515

Open
liujoshua wants to merge 31 commits intoResearchStack:develop-1.5from
liujoshua:feature/separate-compabitility-module
Open

Feature/separate compabitility module#515
liujoshua wants to merge 31 commits intoResearchStack:develop-1.5from
liujoshua:feature/separate-compabitility-module

Conversation

@liujoshua
Copy link
Collaborator

No description provided.

@liujoshua liujoshua requested a review from jdkizer9 July 9, 2019 16:11
@liujoshua liujoshua force-pushed the feature/separate-compabitility-module branch from df74281 to 7fe031d Compare July 9, 2019 17:28
@liujoshua liujoshua force-pushed the feature/separate-compabitility-module branch from 7fe031d to 7158bc0 Compare July 9, 2019 17:38
@jdkizer9
Copy link
Collaborator

So I took a look and I like how it makes it really easy for existing applications to migrate to 2.0. I think what I'm a little confused by is that it looks like at the moment I don't see how old Steps and new Steps can be used in the same Task. It looks like ViewBackboneInteropTaskActivity is doing some translation from old Step to new Step, but maybe we could make an InteropOrderedTask that supports both, probably via a StepAdaptorFactory with a different signature? Or maybe we could create an internal wrapper around the old Steps so that they acted like new Steps? Although this might provide some challenging result wrangling, but maybe that can be resolved with an InteropTaskResult.

Also, can we assume that the Task object that's passed in is an OrderedTask?

@jdkizer9
Copy link
Collaborator

Ok, so I looked into it, and previously both the backbone and the foundation sample apps had a back button in their app bar. The activity should probably be updated to add a back button. Also, when the back button is pressed, the fragment should be initialized based on saved step result for that step.

* Add toolbar back button
* Add StepTitle to toolbar
* Add home soft-button back nav support

TODO: show previously entered values upon back nav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants