Conversation
yossi-k
force-pushed
the
os-fork
branch
3 times, most recently
from
c1de780 to
b94cba7
Compare
youknowone
approved these changes
Jul 26, 2021
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
I personally support hard compatibility with CPython.
At least, leaving comments about CPython implementations for each places will be helpful for future workers.
Member
|
what's happend to the ubuntu tests? |
Member
|
Whatever it is it isn't reproducible, as threads tend to be. Locally it once started spinning on |
Contributor
Author
|
I’ll take another look. The problem is that fork enables functions like os.spawn which in turn enable a whole bunch of new tests. |
Member
|
thanks! This is superseded by #4877 if I'm not mistaken. Feel free to re-open if I'm mistaken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work and tests pass (
test_posix:test_register_at_fork).I took a look at CPython's implementation and it seems they're doing more things before/after fork, namely acquiring the import lock, and re-initiating the interpreter in the child process (see here - https://github.com/python/cpython/blob/main/Modules/posixmodule.c#L593). Do we want to do the same thing here?