Adds __rmul__ to collections.deque#2844
Merged
DimitrisJim merged 4 commits intoRustPython:masterfrom Aug 11, 2021
Merged
Conversation
Contributor
Author
|
Local test produces a very strange result: |
Member
|
|
Member
That's deadlocking, unfortunately. I've idly been trying to find a good way to tackle it. It is for another time, though. |
youknowone
reviewed
Aug 11, 2021
vm/src/stdlib/collections.rs
Outdated
| let mul_len = mul.len(); | ||
| let skipped = match self.maxlen.load() { | ||
| Some(maxlen) if mul_len > maxlen => mul_len - maxlen, | ||
| _ => 0, |
Member
There was a problem hiding this comment.
self.maxlen.load().and_then(|maxlen| mul_len.checked_sub(max_len)).unwrap_or(0)edited wrapping_sub -> checked_sub
DimitrisJim
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2834
Note: at the moment almost all collections are missing
MemoryErrorcorner case, like here: https://github.com/python/cpython/blob/d1ae57027fc39ff60dcfc1b63881400e5ca3ce56/Modules/_collectionsmodule.c#L709-L711I guess that this is out of scope of this task, related:
I think that some tests in
test_dequemight hang because of that.