added getnewargs() to str.rs#3811
Conversation
|
#3807 was recently merged, which changes how CI runs the test suites. Can you rebase your branch on a fresh copy of (Of course, everything after the |
youknowone
left a comment
There was a problem hiding this comment.
Great! you fixed many more than just a single test. Could you please remove expectedFailure decorators from other successful tests?
|
@youknowone How can I know which are successful? |
|
@youknowone Oh, I received message on slack. I'll do that. |
Have you looked at the CI logs? They should give you a clue for where to start looking. |
fanninpm
left a comment
There was a problem hiding this comment.
Some minor cleanup comments, and I think this should be good to go.
fanninpm
left a comment
There was a problem hiding this comment.
I apologize if this wasn't clear, but I meant to say the entirety of the lines. Right now these lines are just redundant, and they can go away (along with the extra whitespace).
|
You mean that delete the test 'functions' which I deleted expectedFailure annotation? |
Any lines that now say def test_function(self):
super().test_function()are just redundant at this point if they're not annotated with a If a test function has something else other than a call to |
|
Is this right? |
fanninpm
left a comment
There was a problem hiding this comment.
This is correct. Thank you!
|
Thank you, too!! |
|
According to the CI, it seems you may have missed a test in |
youknowone
left a comment
There was a problem hiding this comment.
The code changes look good! But maybe you didn't set your git email as your github email.
Do you want to change it before merge?
|
@zer0who please let me know if you don't care about email address. I don't mind to merge it as it is if you are ok. |
Here is GitHub's documentation to set your commit email address. In order to fix these commits, you can run the following commands: |
I don't know exatly that email you mentioned, but I did it as I understanded. Is it right? |
Thank you for your help. It was helpful for me. I'm not good at git... so I think it would be hard to explain to me about those things. But I did my best...!!:) Thank you again. |
|
check |
I forgot to add |
|
Am I right?? |
|
@zer0who Yeah It seems good now 😊 |
Here's how you can tell:
|
Thank you so much :) |
Added getnewargs() to str.rs and have tested on test_unicode.py(test_getnewargs())