Skip to content

Add math.exp2 implemented in cpython 3.11#4150

Merged
youknowone merged 2 commits intoRustPython:mainfrom
jopemachine:add-exp2
Sep 12, 2022
Merged

Add math.exp2 implemented in cpython 3.11#4150
youknowone merged 2 commits intoRustPython:mainfrom
jopemachine:add-exp2

Conversation

@jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Sep 8, 2022 •
edited
Loading

math.exp2 return 2 raised to the power x.

Related links

  • Python codes are copy-pasted from CPython.

@jopemachine jopemachine changed the title Added math.exp2 implemented in cpython 3.11 Add math.exp2 implemented in cpython 3.11 Sep 9, 2022
@youknowone
Copy link
Member

youknowone commented Sep 9, 2022

The rust part looks great. Could you also check if you followed this guideline?
https://github.com/RustPython/RustPython/wiki/How-to-update-test-files

@jopemachine
Copy link
Contributor Author

jopemachine commented Sep 10, 2022 •
edited
Loading

The rust part looks great. Could you also check if you followed this guideline? RustPython/RustPython/wiki/How-to-update-test-files

Thanks for letting me know!
I just made a fixing commit.

I didn't include unrelated diffs with math.exp2 in the commit because I think including these diffs might be out of this PR's scope.

@youknowone
Copy link
Member

youknowone commented Sep 10, 2022

We usually 'sync' our version to a specific CPython version, instead of updating each function. The bulk update is easy by following the guideline.

@jopemachine
Copy link
Contributor Author

jopemachine commented Sep 11, 2022 •
edited
Loading

We usually 'sync' our version to a specific CPython version, instead of updating each function. The bulk update is easy by following the guideline.

Understood. I attached @unittest.expectedFailure to the expected failed tests.

This could be fixed by the other 2 PRs that I made.

youknowone
youknowone approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@youknowone youknowone merged commit fa7a8af into RustPython:main Sep 12, 2022
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

z-ca-2022 Tag to track contrubution-academy 2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jopemachine @youknowone