feat(argparse): update to 3.11#4592
Merged
youknowone merged 2 commits intoRustPython:mainfrom Feb 28, 2023
Merged
Conversation
fanninpm
approved these changes
Feb 28, 2023
Contributor
fanninpm
left a comment
fanninpm
left a comment
There was a problem hiding this comment.
LGTM.
For future reference, I believe you can use the following command to test your changes locally (in a manner similar to RustPython's CI):
# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whateverFor a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.
Member
|
We'd better to add the commands to the issue. |
Member
|
Thank you! |
Contributor
Author
@fanninpm Thanks, I was not aware of that command 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran the tests and seemed ok