Add unittset.expectedFailureIf for RustPython #4597
Merged
fanninpm merged 2 commits intoRustPython:mainfrom Mar 2, 2023
Merged
Add unittset.expectedFailureIf for RustPython #4597fanninpm merged 2 commits intoRustPython:mainfrom
fanninpm merged 2 commits intoRustPython:mainfrom
Conversation
youknowone
force-pushed
the
expected-failure-if
branch
3 times, most recently
from
dbd367e to
27592bc
Compare
youknowone
force-pushed
the
expected-failure-if
branch
from
27592bc to
77ffa85
Compare
youknowone
force-pushed
the
expected-failure-if
branch
from
77ffa85 to
367a948
Compare
DimitrisJim
approved these changes
Mar 2, 2023
Member
DimitrisJim
left a comment
DimitrisJim
left a comment
There was a problem hiding this comment.
looks like a great helper to have
fanninpm
approved these changes
Mar 2, 2023
Contributor
fanninpm
left a comment
fanninpm
left a comment
There was a problem hiding this comment.
We should take care to remove these once all of their usages are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We really need conditional expectedFailure in the name of human right and pain killer.