Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib#4835
Merged
youknowone merged 4 commits intoRustPython:mainfrom Apr 23, 2023
Merged
Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib#4835youknowone merged 4 commits intoRustPython:mainfrom
youknowone merged 4 commits intoRustPython:mainfrom
Conversation
Contributor
|
Hmm… I think we need to split up |
youknowone
force-pushed
the
test_hashlib.py
branch
from
784197e to
8ba6dfd
Compare
Member
|
|
Masorubka1
force-pushed
the
test_hashlib.py
branch
from
8ba6dfd to
6328738
Compare
Masorubka1
changed the title
Masorubka1
changed the title
Contributor
Author
|
@youknowone Could you review this pr? |
fanninpm
reviewed
Apr 18, 2023
youknowone
requested changes
Apr 18, 2023
youknowone
reviewed
Apr 18, 2023
youknowone
requested changes
Apr 18, 2023
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Wow, You made it 👍
Looks mostly good. I left a few comments.
fanninpm
reviewed
Apr 19, 2023
youknowone
requested changes
Apr 21, 2023
Masorubka1
force-pushed
the
test_hashlib.py
branch
from
99ae915 to
a3c810b
Compare
youknowone
force-pushed
the
test_hashlib.py
branch
2 times, most recently
from
40d9194 to
7ea4fc6
Compare
youknowone
force-pushed
the
test_hashlib.py
branch
from
7ea4fc6 to
73e1eeb
Compare
youknowone
approved these changes
Apr 23, 2023
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Thank you! This is great, I like it very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.