updated _collections_abc.py and test_collections.py to CPython 3.11.2#5016
Merged
DimitrisJim merged 2 commits intoRustPython:mainfrom Jun 18, 2023
Merged
Conversation
Member
|
thanks @bobby-palmer, this might be a tricky one 😄 there's two test cases now failing in You can open that file and decorate them with # TODO: RUSTPYTHON
@unittest.expectedFailure
def test_errors(self): # TODO: RUSTPYTHON, remove when this passes
super().test_errors() # TODO: RUSTPYTHON, remove when this passeswhile for # TODO: RUSTPYTHON
@unittest.expectedFailure
def test_valid_uses(self):
.... # function body unchanged |
Contributor
Author
|
@DimitrisJim thanks for the feedback! those tests should be fixed now |
DimitrisJim
approved these changes
Jun 18, 2023
Member
DimitrisJim
left a comment
There was a problem hiding this comment.
nice, guess this wasn't tricky after all. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4564 updating _collections_abc.py to 3.11.2 for Python