Closed
Conversation
hbina
force-pushed
the
hbina-fix-py313-test-fstring
branch
from
d7d967f to
83bf0cd
Compare
youknowone
reviewed
Apr 30, 2025
vm/src/builtins/dict.rs
Outdated
| vm: &VirtualMachine, | ||
| ) -> PyResult<PyObjectRef> { | ||
| if let Some(value) = self.entries.get(vm, key)? { | ||
| let key = key.to_pyobject(vm); |
Member
There was a problem hiding this comment.
could you tell me more what was the motivation of this changes?
Member
There was a problem hiding this comment.
Okay, it seems this is not intended but accidently added to this branch.
Please clean up the branch to only contain fstring changes and push force it.
hbina
force-pushed
the
hbina-fix-py313-test-fstring
branch
from
41253a2 to
7148507
Compare
Signed-off-by: Hanif Ariffin <[email protected]>
hbina
force-pushed
the
hbina-fix-py313-test-fstring
branch
from
7148507 to
ae07b43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.