Skip to content

Add missing @ for the "take" comment command#5933

Merged
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:patch-1
Jul 10, 2025
Merged

Add missing @ for the "take" comment command#5933
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:patch-1

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Jul 10, 2025 •
edited by coderabbitai bot
Loading

Very odd, I have tested this in a private repo and it worked. maybe it needs the @ sign 🤷

Summary by CodeRabbit

  • Chores
    • Updated the GitHub Actions workflow to adjust how issue assignments are handled.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 10, 2025 •
edited
Loading

Walkthrough

The change updates a GitHub Actions workflow by modifying the command used to assign an issue to a user. Specifically, it alters the gh issue edit command to include an "@" prefix before the assignee's username.

Changes

File(s) Change Summary
.github/workflows/comment-commands.yml Updated gh issue edit command to prefix assignee with "@" symbol.

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

A bunny hopped through YAML fields,
Adjusting usernames with care and yields.
Now "@" leads the way,
For assignees each day—
Hooray for tidy workflows, and carrots in the hay! 🥕

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2013cd and be60eea.

📒 Files selected for processing (1)
  • .github/workflows/comment-commands.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.858Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`

Learnt from: ShaharNaveh
PR: RustPython/RustPython#5932
File: .github/workflows/comment-commands.yml:18-24
Timestamp: 2025-07-10T10:08:43.304Z
Learning: In GitHub Actions workflows for the RustPython project, the maintainer ShaharNaveh prefers to keep workflows simple and doesn't mind if steps fail when the desired state is already achieved (e.g., user already assigned to an issue). Avoid suggesting complex error handling for edge cases they don't consider problematic.
.github/workflows/comment-commands.yml (1) 
Learnt from: ShaharNaveh
PR: RustPython/RustPython#5932
File: .github/workflows/comment-commands.yml:18-24
Timestamp: 2025-07-10T10:08:43.304Z
Learning: In GitHub Actions workflows for the RustPython project, the maintainer ShaharNaveh prefers to keep workflows simple and doesn't mind if steps fail when the desired state is already achieved (e.g., user already assigned to an issue). Avoid suggesting complex error handling for edge cases they don't consider problematic.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run tests under miri
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
🔇 Additional comments (1)
.github/workflows/comment-commands.yml (1)

19-19: Adding the required @ prefix – LGTM
gh issue edit --add-assignee expects each login to be @username; this one-liner fixes the command and should unblock the workflow. Good catch.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone merged commit ef385a9 into RustPython:main Jul 10, 2025
12 checks passed
@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Jul 10, 2025

@youknowone it's super odd, I have tried to replicate it in my repo and it works (without the @), I suspect there's something with the actions settings (in the repo settings tab), can you take a look?

ShaharNaveh added a commit to ShaharNaveh/RustPython that referenced this pull request Jul 10, 2025
@ShaharNaveh
Revert "Add missing @ for the "take" comment command (RustPython#5933…
a3819f6 
…)"

This reverts commit ef385a9.
youknowone pushed a commit that referenced this pull request Jul 10, 2025
@ShaharNaveh
Make take issue comment to use curl (#5937)
38837e5 
* Revert "Add missing `@` for the "take" comment command (#5933)"

This reverts commit ef385a9.

* Fix `take`
@ShaharNaveh ShaharNaveh deleted the patch-1 branch July 19, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone