Skip to content

stdlib(sqlite3): Raise ProgrammingError for missing named parameter#6036

Merged
youknowone merged 2 commits intoRustPython:mainfrom
ever0de:fix/sqlite-binding-exception
Jul 25, 2025
Merged

stdlib(sqlite3): Raise ProgrammingError for missing named parameter#6036
youknowone merged 2 commits intoRustPython:mainfrom
ever0de:fix/sqlite-binding-exception

Conversation

@ever0de
Copy link
Contributor

@ever0de ever0de commented Jul 25, 2025 •
edited by coderabbitai bot
Loading

ref

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling for missing values when binding named parameters in SQLite statements, providing clearer error messages if a required value is not supplied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 25, 2025 •
edited
Loading

Walkthrough

The change updates the error handling logic in the bind_parameters_name method of the SqliteStatementRaw implementation. It now explicitly checks for missing dictionary keys when binding named parameters and returns a programming error if a required key is absent, instead of relying on implicit error propagation.

Changes

File(s) Change Summary
stdlib/src/sqlite.rs Updated bind_parameters_name to explicitly check for missing dictionary keys and return a descriptive programming error when a named parameter is not supplied.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

In the warren of code, a bunny did see
A missing key caused quite the spree!
Now with a check, and errors that sing,
Named bindings are safe—what a wonderful thing!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1706b00 and 203c9d3.

📒 Files selected for processing (1)
  • stdlib/src/sqlite.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • stdlib/src/sqlite.rs
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

youknowone
youknowone approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit fb91477 into RustPython:main Jul 25, 2025
12 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ever0de @youknowone