Skip to content

Update dns-lookup and xml-rs (renamed to xml)#6119

Merged
coolreader18 merged 4 commits intoRustPython:mainfrom
ShaharNaveh:update-deps
Sep 1, 2025
Merged

Update dns-lookup and xml-rs (renamed to xml)#6119
coolreader18 merged 4 commits intoRustPython:mainfrom
ShaharNaveh:update-deps

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Sep 1, 2025 •
edited by coderabbitai bot
Loading

Will a PR for dependentabot for cargo be accepted?

Summary by CodeRabbit

  • Chores
    • Updated the XML parsing dependency to the latest major version, improving reliability and compatibility.
    • Upgraded the DNS lookup dependency to the latest major release for non-web targets, enhancing resolution behavior and long-term support.

@ShaharNaveh ShaharNaveh changed the title Update dns-lookup and xml-rs Update dns-lookup and xml-rs (renamed to xml) Sep 1, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 1, 2025 •
edited
Loading

Walkthrough

Updated Rust dependencies in stdlib/Cargo.toml: replaced xml-rs 0.8.14 with xml 1.0, and bumped dns-lookup from 2.1 to 3.0 under the non-wasm32 target dependency section.

Changes

Cohort / File(s) Summary of changes
Dependency updates
stdlib/Cargo.toml		 - Removed xml-rs = "0.8.14"; added xml = "1.0" in [dependencies].
- Updated dns-lookup from "2.1" to "3.0" in [target.'cfg(not(target_arch = "wasm32"))'.dependencies].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hop through crates with careful cheer,
Swapped xml-rs for xml here;
A lookup hops from two to three,
Non-wasm paths now sprout with glee.
Ears up high, dependencies neat—
Tap-tap, merge done—a carrot treat! 🥕

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7509387 and 1fe5fd5.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • stdlib/Cargo.toml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (2)
stdlib/Cargo.toml (2)

108-109: dns-lookup 3.0 is valid
Version “3.0” resolves to the published 3.0.0 on crates.io; no change needed.

Likely an incorrect or invalid review comment.

49-49: xml → xml 1.0 migration safe
pyexpat.rs’s match e { … _ => {} } already provides a catch‐all for new XmlEvent variants (e.g. Doctype), so no further code changes are needed.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coolreader18
coolreader18 approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@coolreader18 coolreader18 merged commit 2b67f40 into RustPython:main Sep 1, 2025
12 checks passed
@ShaharNaveh ShaharNaveh deleted the update-deps branch September 15, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @coolreader18