Skip to content

Replace skips in test_importlib/source/test_file_loader with expectedFailures#6194

Merged
youknowone merged 5 commits intoRustPython:mainfrom
fanninpm:test-importlib-skips-go-bye-bye
Oct 20, 2025
Merged

Replace skips in test_importlib/source/test_file_loader with expectedFailures#6194
youknowone merged 5 commits intoRustPython:mainfrom
fanninpm:test-importlib-skips-go-bye-bye

Conversation

@fanninpm
Copy link
Contributor

@fanninpm fanninpm commented Oct 18, 2025 •
edited
Loading

New trick learned: Did you know you can monkey-patch entire classes using this one simple trick? CPython developers hate this!

Summary by CodeRabbit

Summary? What summary?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/test/test_importlib/source/test_file_loader.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

youknowone
youknowone approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fanninpm
Copy link
Contributor Author

fanninpm commented Oct 18, 2025

Windows CI failures are due to OpenSSL not building correctly. I have no idea what to do for the WASM CI failure.

@youknowone
Copy link
Member

youknowone commented Oct 20, 2025

I have no idea too. But this patch doesn't seem to be related.

@youknowone youknowone merged commit 3473d82 into RustPython:main Oct 20, 2025
17 of 23 checks passed
@fanninpm fanninpm deleted the test-importlib-skips-go-bye-bye branch October 21, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

@youknowone youknowone

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanninpm @youknowone