Skip to content

Move stdlib -> crates/stdlib#6268

Merged
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:move-stdlib
Nov 16, 2025
Merged

Move stdlib -> crates/stdlib#6268
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:move-stdlib

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Nov 15, 2025 •
edited by coderabbitai bot
Loading

ref: #6214

Summary by CodeRabbit

  • Chores
    • Reorganized project layout to improve structure and maintainability.
    • Updated internal dependency references to match the new layout, ensuring consistent build and dependency resolution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2025 •
edited
Loading

Walkthrough

The workspace Cargo.toml was updated: the top-level workspace member stdlib was removed and the rustpython-stdlib workspace dependency path was changed from stdlib to crates/stdlib.

Changes

Cohort / File(s) Change Summary
Workspace configuration
Cargo.toml		 Removed stdlib from [workspace] members; updated [workspace.dependencies] entry for rustpython-stdlib to use path crates/stdlib instead of stdlib.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Points to check:

  • Ensure no CI scripts, build tooling, or other Cargo.toml files reference the removed top-level stdlib path.
  • Confirm other workspace dependency paths still resolve to the intended crates/ locations.

Possibly related PRs

Poem

🐰 I nudged the Cargo map tonight,

Moved stdlib to a cozier site.
Crates in rows, a tidy scene,
Builds hum soft and errors lean.
Hooray — a hop, a patch, a bite! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Move stdlib -> crates/stdlib' directly and clearly describes the main change: relocating the stdlib directory to a new path under crates/, which aligns with the file modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1586f29 and df6734a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Check Rust code with clippy
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: auto_format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh mentioned this pull request Nov 15, 2025
Open
16 tasks
@youknowone
Copy link
Member

youknowone commented Nov 15, 2025

let me do this after #6244. It will be easier

@youknowone youknowone merged commit 88eca96 into RustPython:main Nov 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone