Skip to content

Update the signal + socketserver libraries + associated tests - v3.13.11#6631

Merged
youknowone merged 6 commits intoRustPython:mainfrom
terryluan12:update_signal_socket
Jan 3, 2026
Merged

Update the signal + socketserver libraries + associated tests - v3.13.11#6631
youknowone merged 6 commits intoRustPython:mainfrom
terryluan12:update_signal_socket

Conversation

@terryluan12
Copy link
Contributor

@terryluan12 terryluan12 commented Jan 3, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 3, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • Lib/socketserver.py is excluded by !Lib/**
  • Lib/test/test_signal.py is excluded by !Lib/**
  • Lib/test/test_socketserver.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12
Copy link
Contributor Author

terryluan12 commented Jan 3, 2026

The subsocket.py file remains the same

@youknowone
Copy link
Member

youknowone commented Jan 3, 2026

macos failure is looking unrelated. i am investigating

@terryluan12
Copy link
Contributor Author

terryluan12 commented Jan 3, 2026

macos failure is looking unrelated. i am investigating

Oh. Whoops. I did not see this. Sorry about that. Let me know if I should undo the changes

youknowone
youknowone reviewed Jan 3, 2026
View reviewed changes
Lib/test/test_ftplib.py Outdated
self.assertEqual(ftplib.parse257('257 "/foo/b""ar"'), '/foo/b"ar')
self.assertEqual(ftplib.parse257('257 "/foo/b""ar" created'), '/foo/b"ar')

@unittest.skipIf(sys.platform == "darwin", "TODO: RUSTPYTHON")
Copy link
Member

@youknowone youknowone Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6635 will fix this regession

youknowone
youknowone approved these changes Jan 3, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youknowone youknowone merged commit eea6cc4 into RustPython:main Jan 3, 2026
12 of 13 checks passed
@terryluan12 terryluan12 mentioned this pull request Jan 3, 2026
Closed
@terryluan12 terryluan12 changed the title Update the signal + socket libraries + associated tests - v3.13.11 Update the signal + socketserver libraries + associated tests - v3.13.11 Jan 5, 2026
@terryluan12 terryluan12 deleted the update_signal_socket branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terryluan12 @youknowone