Skip to content

Add some compiler tests from 3.13.11#6752

Merged
youknowone merged 3 commits intoRustPython:mainfrom
ShaharNaveh:test-add-compiler-assembler
Jan 17, 2026
Merged

Add some compiler tests from 3.13.11#6752
youknowone merged 3 commits intoRustPython:mainfrom
ShaharNaveh:test-add-compiler-assembler

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Jan 17, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • Lib/test/test_compiler_assemble.py is excluded by !Lib/**
  • Lib/test/test_compiler_codegen.py is excluded by !Lib/**
  • Lib/test/test_peepholer.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
Copy link
Member

youknowone commented Jan 17, 2026 •
edited
Loading

Usually we can take a lower version patch first and update it later. But #6718 heavily updated compiler due to annotation changes, I'd like to ensure this is 3.14 compatible.
Could you please update this patch to Python 3.14?

Or simply rebase and rerun will be also okay

youknowone
youknowone approved these changes Jan 17, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 892116c into RustPython:main Jan 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone