Skip to content

Bump logging, re, fnmatch, glob, mimetypes, urllib, pathlib to 3.14.2#6784

Closed
moreal wants to merge 9 commits intoRustPython:mainfrom
moreal:bump-3.14-logging-re-fnmatch-glob
Closed

Bump logging, re, fnmatch, glob, mimetypes, urllib, pathlib to 3.14.2#6784
moreal wants to merge 9 commits intoRustPython:mainfrom
moreal:bump-3.14-logging-re-fnmatch-glob

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Jan 18, 2026 •
edited
Loading

This pull request bumps logging, re, fnmatch, glob, mimetypes, urllib, pathlib to 3.14.2.

I apologize that the PR has become quite large while trying to pass CI. I tried to split it by commits to make reviewing easier, but if it would be better to split the PR, I will do so.

How to review

I'm keeping this as a record because it was useful during the review process, and we also used it when entrusting the task to an LLM and reviewing it.

  1. Ensure there is cpython/ directory
  2. Run git show sha (or git show HEAD~2) to check if there are any accidental arbitrary modifications that have disappeared. (It can be reviewed in GitHub diff)
  3. Run delta Lib/<lib>.py cpython/Lib/<lib>.py and delta Lib/test/<lib>.py cpython/Lib/test/<lib>.py,
    or delta Lib/<lib>/ cpython/Lib/<lib>/ and delta Lib/test/test_<lib>/ cpython/Lib/test/test_<lib>/,
    to ensure that CPython has been updating properly and that no strange values have been inserted.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (46)
  • Lib/fnmatch.py is excluded by !Lib/**
  • Lib/glob.py is excluded by !Lib/**
  • Lib/logging/__init__.py is excluded by !Lib/**
  • Lib/logging/config.py is excluded by !Lib/**
  • Lib/logging/handlers.py is excluded by !Lib/**
  • Lib/mimetypes.py is excluded by !Lib/**
  • Lib/pathlib/__init__.py is excluded by !Lib/**
  • Lib/pathlib/_abc.py is excluded by !Lib/**
  • Lib/pathlib/_local.py is excluded by !Lib/**
  • Lib/pathlib/_os.py is excluded by !Lib/**
  • Lib/pathlib/types.py is excluded by !Lib/**
  • Lib/re/__init__.py is excluded by !Lib/**
  • Lib/re/_compiler.py is excluded by !Lib/**
  • Lib/re/_constants.py is excluded by !Lib/**
  • Lib/re/_parser.py is excluded by !Lib/**
  • Lib/test/test_fnmatch.py is excluded by !Lib/**
  • Lib/test/test_glob.py is excluded by !Lib/**
  • Lib/test/test_httplib.py is excluded by !Lib/**
  • Lib/test/test_httpservers.py is excluded by !Lib/**
  • Lib/test/test_logging.py is excluded by !Lib/**
  • Lib/test/test_mimetypes.py is excluded by !Lib/**
  • Lib/test/test_pathlib/support/__init__.py is excluded by !Lib/**
  • Lib/test/test_pathlib/support/lexical_path.py is excluded by !Lib/**
  • Lib/test/test_pathlib/support/local_path.py is excluded by !Lib/**
  • Lib/test/test_pathlib/support/zip_path.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_copy.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_join.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_join_posix.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_join_windows.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_pathlib.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_pathlib_abc.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_read.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_write.py is excluded by !Lib/**
  • Lib/test/test_re.py is excluded by !Lib/**
  • Lib/test/test_robotparser.py is excluded by !Lib/**
  • Lib/test/test_ssl.py is excluded by !Lib/**
  • Lib/test/test_urllib.py is excluded by !Lib/**
  • Lib/test/test_urllib2.py is excluded by !Lib/**
  • Lib/test/test_urllib2_localnet.py is excluded by !Lib/**
  • Lib/test/test_urllib2net.py is excluded by !Lib/**
  • Lib/test/test_urllibnet.py is excluded by !Lib/**
  • Lib/test/test_urlparse.py is excluded by !Lib/**
  • Lib/test/test_warnings/__init__.py is excluded by !Lib/**
  • Lib/urllib/parse.py is excluded by !Lib/**
  • Lib/urllib/request.py is excluded by !Lib/**
  • Lib/urllib/robotparser.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moreal moreal marked this pull request as draft January 18, 2026 15:05
@moreal moreal changed the title Bump logging, re, fnmatch, glob to 3.14.2 Bump logging, re, fnmatch, glob, mimetypes, urllib, pathlib to 3.14.2 Jan 18, 2026
@moreal moreal force-pushed the bump-3.14-logging-re-fnmatch-glob branch from 74bc60d to 57da0e8 Compare January 18, 2026 20:40
@moreal moreal marked this pull request as ready for review January 18, 2026 21:58
@moreal moreal marked this pull request as draft January 19, 2026 08:45
@moreal
Copy link
Contributor Author

moreal commented Jan 19, 2026 •
edited
Loading

This pull request will be separated each PR and will be closed.

  • re
  • mimetypes
  • logging
  • fnmatch
  • glob
  • urllib
  • pathlib

This was referenced Jan 20, 2026
Merged
Merged
@moreal
Copy link
Contributor Author

moreal commented Jan 23, 2026

I close this pull request and I'll make with /upgrade-pylib again.

@moreal moreal closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@moreal