Skip to content

Bump mimetypes to 3.14.2#6808

Merged
youknowone merged 3 commits intoRustPython:mainfrom
moreal:bump-3.14.2-mimetypes
Jan 21, 2026
Merged

Bump mimetypes to 3.14.2#6808
youknowone merged 3 commits intoRustPython:mainfrom
moreal:bump-3.14.2-mimetypes

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Jan 20, 2026

This pull request is extracted from #6784

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (6)
  • Lib/mimetypes.py is excluded by !Lib/**
  • Lib/test/test_httplib.py is excluded by !Lib/**
  • Lib/test/test_httpservers.py is excluded by !Lib/**
  • Lib/test/test_mimetypes.py is excluded by !Lib/**
  • Lib/test/test_ssl.py is excluded by !Lib/**
  • Lib/test/test_urllib2.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moreal moreal force-pushed the bump-3.14.2-mimetypes branch 2 times, most recently from ae27e00 to 21334ff Compare January 20, 2026 10:36
@moreal
Copy link
Contributor Author

moreal commented Jan 20, 2026 •
edited
Loading

The job run on window-2025 has failed with the following lines. It seems not related about updating mimetypes module to 3.14.2 🤔

======================================================================
FAIL: test_socketserver (test.test_ssl.ThreadedTests.test_socketserver)
Using socketserver to create and manage SSL connections.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\RustPython\RustPython\Lib\test\test_ssl.py", line 3552, in test_socketserver
    self.assertEqual(d1, d2)
                         ^^
AssertionError: b'# Test the support for SSL and sockets\r\[254224 chars]\r\n' != b''

----------------------------------------------------------------------

@moreal moreal marked this pull request as ready for review January 20, 2026 11:13
youknowone
youknowone reviewed Jan 21, 2026
View reviewed changes
Lib/test/test_ssl.py
else:
s.close()

@unittest.expectedFailure # TODO: RUSTPYTHON
Copy link
Member

@youknowone youknowone Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this line

Copy link
Contributor Author

@moreal moreal Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't have Windows machine, I cannot check the test but it seems to fail in only Windows environment. I'll mark it as unittest.expectedFailureIfWindows.

In my local macOS environment, the following command doesn't fail.

cargo run --release -- -m unittest test.test_ssl.ThreadedTests.test_socketserver

@moreal moreal force-pushed the bump-3.14.2-mimetypes branch from 21334ff to 7a31b09 Compare January 21, 2026 09:35
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

Click to expand dependency information 
[+] lib: cpython/Lib/mimetypes.py
[+] test: cpython/Lib/test/test_mimetypes.py
soft_deps:
- [x] mimetypes

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated
  • native: Rust/C extension modules

@moreal moreal requested a review from youknowone January 21, 2026 10:41
youknowone
youknowone approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit ce1bbc7 into RustPython:main Jan 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moreal @youknowone